fix: ensure activity name is used when activity label is not defined #153
+48
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the activityLabel method to check if the label is explicitly set for the Activity. If not, it will return null instead of the application label. Added activityName to return activityName class Updated onActivityStarted to use activityName as a fallback if activityLabel is null.
- Combined activityLabel and activityName methods into a single method activityLabelOrName. - The new method retrieves the activity label if it differs from the application label. - If the labels are identical or the activity label is empty, it falls back to the activity's class name.
… method - Replaced the separate calls to activityLabel and activityName with a single call to activityLabelOrName.
…tion label - Added parameters for activity name and application label to the mockScreenTitle function.
- Updated tests in PostHogActivityLifecycleCallbackIntegrationTest to verify activity label and application label handling. - Added scenarios to ensure the correct behavior when labels are the same or empty.
marandaneto
reviewed
Aug 7, 2024
...id/src/main/java/com/posthog/android/internal/PostHogActivityLifecycleCallbackIntegration.kt
Outdated
Show resolved
Hide resolved
|
it does not fix #150 but addresses another issue. |
|
@thisames would add a new item to the changelog file https://github.com/PostHog/posthog-android/blob/main/CHANGELOG.md ? |
for sure =) |
marandaneto
approved these changes
Aug 8, 2024
|
@thisames type |
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
The loadLabel method was loading the application label when an activity label was not defined. This change ensures that when an activity label is not defined, it defaults to the activity name instead of the application label. This improves the accuracy of screen name logging.
fix #150
💚 How did you test it?
📝 Checklist