Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: add headerflags and ednsVersion as fields in protobuf messages #14852

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

omoerbeek
Copy link
Member

Short description

Please check the boundary change in getQNameAndSubnet extra carefully.

This only adds the two new fields to the PB messages generated for client requests.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@coveralls
Copy link

coveralls commented Nov 19, 2024

Pull Request Test Coverage Report for Build 11951172813

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 30 of 31 (96.77%) changed or added relevant lines in 4 files are covered.
  • 128 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-0.06%) to 64.674%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/recursordist/rec-tcp.cc 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/recursordist/lwres.cc 2 70.09%
pdns/recursordist/sortlist.cc 2 74.12%
pdns/iputils.cc 3 55.91%
pdns/rcpgenerator.cc 3 89.47%
pdns/recursordist/aggressive_nsec.cc 4 66.1%
pdns/recursordist/rec-tcp.cc 4 65.15%
pdns/dnsdistdist/dnsdist-carbon.cc 6 62.16%
pdns/recursordist/syncres.cc 7 79.5%
pdns/recursordist/test-syncres_cc1.cc 8 89.58%
Totals Coverage Status
Change from base Build 11915618754: -0.06%
Covered Lines: 125797
Relevant Lines: 163631

💛 - Coveralls

pdns/dnsmessage.proto Outdated Show resolved Hide resolved
pdns/dnsmessage.proto Outdated Show resolved Hide resolved
pdns/recursordist/pdns_recursor.cc Outdated Show resolved Hide resolved
- rename needECS to needEDNSParse
- remove lookForECS in getQNameAndSubnet
- extend test to include packet cache hit case
- take new dnsmessage.proto form dnsmessage repo
pdns/recursordist/pdns_recursor.cc Outdated Show resolved Hide resolved
Co-authored-by: Remi Gacogne <github@coredump.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants