-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rec: add headerflags and ednsVersion as fields in protobuf messages #14852
Open
omoerbeek
wants to merge
7
commits into
PowerDNS:master
Choose a base branch
from
omoerbeek:rec-add-pb-edns-hdr
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+108
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11951172813Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
omoerbeek
force-pushed
the
rec-add-pb-edns-hdr
branch
from
November 19, 2024 13:18
3888db7
to
ea9d3de
Compare
omoerbeek
force-pushed
the
rec-add-pb-edns-hdr
branch
from
November 19, 2024 15:03
ea9d3de
to
ce932a7
Compare
rgacogne
reviewed
Nov 21, 2024
- rename needECS to needEDNSParse - remove lookForECS in getQNameAndSubnet - extend test to include packet cache hit case - take new dnsmessage.proto form dnsmessage repo
rgacogne
approved these changes
Nov 22, 2024
Co-authored-by: Remi Gacogne <github@coredump.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Please check the boundary change in
getQNameAndSubnet
extra carefully.This only adds the two new fields to the PB messages generated for client requests.
Checklist
I have: