-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Architecture Overhaul, and Performance Improvements #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to testnet_pretask
… reduce default rpc polling interval to 10 seconds
…r_id_check Testnet pretask: snapshotter id check
…ve default values
…to testnet_5_pairs
xadahiya
changed the title
Feat: Submodule architecture with architecture and perf improvements
Architecture Overhaul, and Performance Improvements
Nov 26, 2023
anomit
reviewed
Nov 27, 2023
anomit
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
anomit
reviewed
Nov 27, 2023
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses and closes issue #47 while introducing significant architectural enhancements and performance optimizations.
Checklist
Changes
Incorporates fixes from PRs #45, #50, and #53.
New Architecture
This revamped architecture transforms the snapshotter into a more modular and highly configurable system, fostering easy customization and seamless integration. The architecture comprises three core components:
Main Snapshotter Codebase:
Configuration Files:
/config
directory, these files play a pivotal role in defining project types, specifying paths for individual compute modules, and managing various project-related settings.Compute Modules:
snapshotter/modules
directory, these modules constitute the system's core, defining the computation logic for each project type and steering the snapshot generation process.This architecture promotes the seamless interchange of configurations and modules. By maintaining these components in separate Git repositories, integrated through Git Submodules, adapting the system to different use cases becomes as straightforward as changing a Git branch. This approach offers unparalleled flexibility and versatility.
Learn more about using Git Submodules in the Git Submodules Documentation.
Other Changes and Improvements