-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Existing Generative Tutorials #1769
Comments
Most of the tutorials merely require the changes mentioned above except for the following:
|
Hi @ericspod , As our ETA is end of this month, could you please help split the tasks directly based on the effort in your mind? Thanks in advance. |
I will take on the porting of 2d_spade_gan and 2D_spade_ldm, as well as 3d_brainsmask_controlnet from August 17th onwards, as per what I discussed in my previous comment. |
Hi @yiheng-wang-nv , could you please help also pick several of the tutorials to port? Thanks in advance. |
I'm going to start with the 2D and 3D LDM tutorials in GenerativeModels. These are single notebooks which differ significantly in content from the existing LDM tutorials (https://github.com/Project-MONAI/tutorials/tree/main/generative/2d_ldm and https://github.com/Project-MONAI/tutorials/tree/main/generative/3d_ldm), so we have 4 tutorials here to check. I'll make sure the ones from GenerativeModels work first then those already here, and see how to best combine both. |
I will work in the order of:
Will update this ticket when having any progrsses |
Hi @ericspod , Thanks for your testing here, may I know why you want to test the "2D and 3D LDM tutorials in GenerativeModels"? I think maybe we can start the MONAI tutorials directly? Thanks. |
These should be fast to check and then move over, the ones in |
Addresses part of #1769. ### Description This updates the tutorials for LDM models and copies over the notebooks from the GenerativeModels repo. These notebooks have been checked, the 3D one has its code updated but cell outputs left as-is to save time so may need checking later. The MAISI tutorial was untouched but should be updated as well. ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [ ] Avoid including large-size files in the PR. - [ ] Clean up long text outputs from code cells in the notebook. - [ ] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
I'll start working on anomaly_detection for now, and I'll likely get around to a few more next week |
I'm going to pick up the other 2D tutorials, hopefully these will be fast. the 3D DDPM tutorial works but I can't get good results out of it for some reason so far. |
Address some of #1769. ### Description These are the 2D ~~and 3D~~ DDPM tutorials. I have run them again to verify they work. ~~The 2D ones are fine but the 3D tutorial keeps having mode collapse or some other issue resulting in bad results. Work is ongoing on this one.~~ I have left the 3D tutorial off since it's not training stably and needs some revamp to be a proper and useful tutorial for users. ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Avoid including large-size files in the PR. - [x] Clean up long text outputs from code cells in the notebook. - [x] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [x] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [x] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Address some of Project-MONAI#1769. ### Description These are the 2D ~~and 3D~~ DDPM tutorials. I have run them again to verify they work. ~~The 2D ones are fine but the 3D tutorial keeps having mode collapse or some other issue resulting in bad results. Work is ongoing on this one.~~ I have left the 3D tutorial off since it's not training stably and needs some revamp to be a proper and useful tutorial for users. ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Avoid including large-size files in the PR. - [x] Clean up long text outputs from code cells in the notebook. - [x] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [x] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [x] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Address some of #1769. ### Description This adds a few more tutorials from the GenerativeModels Repo ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [ ] Avoid including large-size files in the PR. - [ ] Clean up long text outputs from code cells in the notebook. - [ ] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
3D DDPM tutorial is now up for review, it works now reliably. |
Address some of #1769. ### Description This adds the missing 3d DDPM tutorial which now functions. ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Avoid including large-size files in the PR. - [x] Clean up long text outputs from code cells in the notebook. - [x] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [x] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
The last item in our list can be addressed separately so I'm going to call this issue completed. |
Is your feature request related to a problem? Please describe.
We have the following to port:
Let's divide amongst assignees and go from there. For each tutorial in the generative repo we should:
distributed_training/ddpm_training_ddp.py
is the only one).GenerativeModels
to those inMONAI
.The text was updated successfully, but these errors were encountered: