-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDPM Tutorials #1814
DDPM Tutorials #1814
Conversation
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I'm still trying to get good results for the 3D example so not ready for review yet. |
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
We're going to leave the 3D tutorial for later, it is not training stably at the moment and isn't a good examplar as a consequence. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Overall looks good to me. Minor comments inline.
And could you please also update the README file here: https://github.com/Project-MONAI/tutorials/blob/main/generation/README.md? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides existing comments, they look fine by me.
Hi @ericspod, I just disable the auto-merge since the premerge-notebook is not a required one to test. Want to double-confirm. Perhaps we need set it to required test. |
It should be required I'd say, unless there was some reason why notebooks would fail but still be mergable. |
Let me try whether I have permission to set. |
Address some of Project-MONAI#1769. ### Description These are the 2D ~~and 3D~~ DDPM tutorials. I have run them again to verify they work. ~~The 2D ones are fine but the 3D tutorial keeps having mode collapse or some other issue resulting in bad results. Work is ongoing on this one.~~ I have left the 3D tutorial off since it's not training stably and needs some revamp to be a proper and useful tutorial for users. ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Avoid including large-size files in the PR. - [x] Clean up long text outputs from code cells in the notebook. - [x] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [x] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [x] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Address some of #1769.
Description
These are the 2D
and 3DDDPM tutorials. I have run them again to verify they work.The 2D ones are fine but the 3D tutorial keeps having mode collapse or some other issue resulting in bad results. Work is ongoing on this one.I have left the 3D tutorial off since it's not training stably and needs some revamp to be a proper and useful tutorial for users.Checks
./figure
folder./runner.sh -t <path to .ipynb file>