-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port LDM Tutorials #1775
Port LDM Tutorials #1775
Conversation
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
…to port_ldm_tutorials
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Thank you so much for the PR! May I ask if you have run the tutorials for LDM models, including the multi-gpu script? LGTM. Thank you! |
Hi @ericspod, please help remove the output from these cells to help resolve the ci issue. |
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Still one more place need to update: https://github.com/Project-MONAI/tutorials/actions/runs/10369757784/job/28706169443?pr=1775 |
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
The guidelines should be met now, we should check that the |
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
I find there are still one place in ldm need to be updated: |
Addresses part of #1769.
Description
This updates the tutorials for LDM models and copies over the notebooks from the GenerativeModels repo. These notebooks have been checked, the 3D one has its code updated but cell outputs left as-is to save time so may need checking later. The MAISI tutorial was untouched but should be updated as well.
Checks
./figure
folder./runner.sh -t <path to .ipynb file>