Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port LDM Tutorials #1775

Merged
merged 12 commits into from
Aug 13, 2024
Merged

Port LDM Tutorials #1775

merged 12 commits into from
Aug 13, 2024

Conversation

ericspod
Copy link
Member

@ericspod ericspod commented Aug 9, 2024

Addresses part of #1769.

Description

This updates the tutorials for LDM models and copies over the notebooks from the GenerativeModels repo. These notebooks have been checked, the 3D one has its code updated but cell outputs left as-is to save time so may need checking later. The MAISI tutorial was untouched but should be updated as well.

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ericspod ericspod requested a review from KumoLiu August 9, 2024 13:50
@ericspod ericspod mentioned this pull request Aug 9, 2024
20 tasks
pre-commit-ci bot and others added 4 commits August 9, 2024 13:52
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
@Can-Zhao
Copy link
Contributor

Can-Zhao commented Aug 12, 2024

Thank you so much for the PR! May I ask if you have run the tutorials for LDM models, including the multi-gpu script? LGTM. Thank you!

generation/2d_ldm/2d_ldm_tutorial.ipynb Show resolved Hide resolved
generation/2d_ldm/2d_ldm_tutorial.ipynb Show resolved Hide resolved
generation/2d_ldm/2d_ldm_tutorial.ipynb Show resolved Hide resolved
generation/2d_ldm/2d_ldm_tutorial.ipynb Show resolved Hide resolved
generation/2d_ldm/2d_ldm_tutorial.ipynb Show resolved Hide resolved
generation/3d_ldm/3d_ldm_tutorial.ipynb Show resolved Hide resolved
generation/3d_ldm/3d_ldm_tutorial.ipynb Show resolved Hide resolved
generation/3d_ldm/3d_ldm_tutorial.ipynb Show resolved Hide resolved
generation/3d_ldm/3d_ldm_tutorial.ipynb Show resolved Hide resolved
generation/3d_ldm/3d_ldm_tutorial.ipynb Show resolved Hide resolved
ericspod and others added 2 commits August 12, 2024 19:18
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
@KumoLiu
Copy link
Contributor

KumoLiu commented Aug 13, 2024

Hi @ericspod, please help remove the output from these cells to help resolve the ci issue.
https://github.com/Project-MONAI/tutorials/actions/runs/10357197347/job/28668716848?pr=1775

Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
@KumoLiu
Copy link
Contributor

KumoLiu commented Aug 13, 2024

Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
@ericspod
Copy link
Member Author

The guidelines should be met now, we should check that the max_epochs replacement is working and things aren't too slow.

@ericspod ericspod enabled auto-merge (squash) August 13, 2024 13:25
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
@ericspod ericspod merged commit 7d2c225 into Project-MONAI:main Aug 13, 2024
6 checks passed
@ericspod ericspod deleted the port_ldm_tutorials branch August 13, 2024 17:34
@KumoLiu
Copy link
Contributor

KumoLiu commented Aug 15, 2024

I find there are still one place in ldm need to be updated:
https://github.com/Project-MONAI/tutorials/blob/main/generation/3d_ldm/inference.py#L23

@KumoLiu
Copy link
Contributor

KumoLiu commented Aug 15, 2024

cc @ericspod @Can-Zhao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants