-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix node_link_json
type annotation
#1247
Merged
IvanIsCoding
merged 10 commits into
Qiskit:main
from
IvanIsCoding:fix-json-type-annotation
Sep 30, 2024
Merged
Fix node_link_json
type annotation
#1247
IvanIsCoding
merged 10 commits into
Qiskit:main
from
IvanIsCoding:fix-json-type-annotation
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanIsCoding
added
the
stable-backport-potential
This PR or issue is potentially worth backporting for inclusion in a stable branch
label
Jul 11, 2024
Pull Request Test Coverage Report for Build 11114945229Details
💛 - Coveralls |
mtreinish
approved these changes
Sep 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'm a bit surprised this got through the tests but this is clearly correct.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sep 29, 2024
I think our merge queue is stuck, do we need to tweak the CI configs? https://github.com/Qiskit/rustworkx/queue/main |
mergify bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
* Fix node_link_json type annotations * Add release notes * Try to fix link * Try to fix merge queue hanging (cherry picked from commit 6096c8f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
stable-backport-potential
This PR or issue is potentially worth backporting for inclusion in a stable branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1243
We let this one slip through by accident.