Issues found while refactoring workflow.pacta.report

[AlexAxthelm]

• import reframe from dplyr
• Add namespace to function

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 0.81%. Comparing base (9f32a19) to head (8c9186e).

Files	Patch %	Lines
R/create_interactive_report.R	0.00%	1 Missing ⚠️

Additional details and impacted files

@@          Coverage Diff          @@
##            main     #78   +/-   ##
=====================================
  Coverage   0.81%   0.81%           
=====================================
  Files         25      25           
  Lines       1596    1596           
=====================================
  Hits          13      13           
  Misses      1583    1583           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cjyetman]

sorry retrospectively, but... seems off that this file is necessary for just dplyr::reframe, probably suggests that this is unnecessarily a new and unique method (to this repo) of importing a function

[jdhoffa]

My preferred method is usually to use an imports.R file: https://github.com/RMI-PACTA/r2dii.analysis/blob/main/R/imports.R

but that doesn't seem to be the Beta in pacta.portfolio.report? Unless there is a different approach already implemented here?

[AlexAxthelm]

It looks like we were already using the R package standard of putting importFroms in NAMESPACE, but usethis::use_import_from() requires having the package-level docs.