Refactor/11 convert to package #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package installation is not working, see r-lib/pak, Issue #638
Docker build status
|
jdhoffa
previously approved these changes
Jun 3, 2024
AlexAxthelm
dismissed
jdhoffa’s stale review
The merge-base changed after approval.
jdhoffa
previously approved these changes
Jun 3, 2024
jdhoffa
previously approved these changes
Jun 3, 2024
AlexAxthelm
dismissed
jdhoffa’s stale review
The merge-base changed after approval.
cjyetman
reviewed
Jun 4, 2024
cjyetman
reviewed
Jun 4, 2024
.github/workflows/test.yml
Outdated
Comment on lines
117
to
128
| --network none \ | ||
| --env LOG_LEVEL=TRACE \ | ||
| --env ANALYSIS_OUTPUT_DIR="/mnt/analysis_output_dir" \ | ||
| --env BENCHMARKS_DIR="/mnt/benchmarks_dir" \ | ||
| --env REPORT_OUTPUT_DIR="/mnt/report_output_dir" \ | ||
| --env SUMMARY_OUTPUT_DIR="/mnt/summary_output_dir" \ | ||
| --mount type=bind,readonly,source=${WORKSPACE}/${BENCHMARKS_DIR},target=/mnt/benchmarks_dir \ | ||
| --mount type=bind,readonly,source=${WORKSPACE}/${ANALYSIS_OUTPUT_DIR},target=/mnt/analysis_output_dir \ | ||
| --mount type=bind,source=${WORKSPACE}/${REPORT_OUTPUT_DIR},target=/mnt/report_output_dir \ | ||
| --mount type=bind,source=${WORKSPACE}/${SUMMARY_OUTPUT_DIR},target=/mnt/summary_output_dir \ | ||
| $FULL_IMAGE_NAME \ | ||
| $PARAMETERS |
cjyetman
reviewed
Jun 4, 2024
Dockerfile
Outdated
| ARG DEBCONF_NOWARNINGS="yes" | ||
| LABEL org.opencontainers.image.title="workflow.pacta.report" | ||
| LABEL org.opencontainers.image.vendor="RMI" | ||
| LABEL org.opencontainers.image.base.name="ghcr.io/rmi-pacta/workflow.pacta:main" |
There was a problem hiding this comment.
nit: probably should match base defined above docker.io/rocker/r-ver:4.3.1 AS base
cjyetman
reviewed
Jun 4, 2024
cjyetman
reviewed
Jun 4, 2024
R/run_pacta_reporting_process.R
Outdated
| pacta.portfolio.utils::quit_if_no_pacta_relevant_data(total_portfolio) | ||
| } else { | ||
| log_warn("file \"{total_portfolio_path}\" does not exist.") | ||
| warning("This is weird... the `total_portfolio.rds` file does not exist in the `30_Processed_inputs` directory.") |
There was a problem hiding this comment.
nit: does 30_Processed_inputs still exist in this context?
cjyetman
reviewed
Jun 4, 2024
cjyetman
reviewed
Jun 4, 2024
cjyetman
reviewed
Jun 4, 2024
cjyetman
approved these changes
Jun 4, 2024
Co-authored-by: CJ Yetman <cj@cjyetman.com>
cjyetman
approved these changes
Jun 5, 2024
|
Closing since something is messed up with the approvals, will reopen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manifest ExportAdd Manifest Export #20Generate Results if neededTo be doneworkflow.pacta.webappDeal withNonblocking, can deal with in that repo.gitwarnings increate_interactive_reportCloses #11
Depends On RMI-PACTA/pacta.portfolio.report#78