Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/11 convert to package #21

Merged
merged 117 commits into from
Jun 11, 2024
Merged

Refactor/11 convert to package #21

merged 117 commits into from
Jun 11, 2024

Conversation

AlexAxthelm
Copy link
Contributor

Re-opening of #17, since something was messed up in the approval flow there.

@AlexAxthelm
Reflect new directory structure
4280d5f
@AlexAxthelm
Working build
0e8774a
@AlexAxthelm
add script, lightly modified from workflow.pacta
aa5f323
@AlexAxthelm
Move main script
96cf164
@AlexAxthelm
Call an argumentless function as entrypoint
f90ad2e
@AlexAxthelm
Move main script
345a496
@AlexAxthelm
Call an argumentless function as entrypoint
bf286de
@AlexAxthelm
Add testing configs from workflow.pacta
cacf5f5
@AlexAxthelm
Import logger functions
628a32b
@AlexAxthelm
Add run_pacta script
1b1da7a
@AlexAxthelm
Call new script from Dockerfile
ce1257b
@AlexAxthelm
Create dir before chmodding
cdfba5e
@AlexAxthelm
Update Rbuildignore and dockerignore
88b1175
@AlexAxthelm
Use import logging functions from package namespace
45a58a8
@AlexAxthelm
Update upload URL
1041569
@AlexAxthelm
Use default testing portfolio for analysis results
b5bccb3
@AlexAxthelm
fix line continuation
2b9a7ba
@AlexAxthelm
Factor utility functions to separate file
f1dd139
@AlexAxthelm
Remove TODO
a71202b 
#19
@AlexAxthelm
linting
9d44006
@AlexAxthelm
Remove second chmod
0d510c0
@AlexAxthelm
render Docs
3dadeb2
@AlexAxthelm
import log_debug
f558892
@AlexAxthelm
Add R checks from RMI-PACTA/actions
ae8abf0
@AlexAxthelm
Remove unused variables
2482339
@AlexAxthelm
Report image doesn't need a portfolio mount
3adcfc8
@AlexAxthelm
Remove unused shell script
835c087
@AlexAxthelm
Merge commit '2482339' into add-tests
8287ae1
@AlexAxthelm
Namespace functions from pacta.portfolio.utils
e9685b3
@AlexAxthelm
Namespace functions from pacta.portfolio.report
6f16d2f
AlexAxthelm and others added 22 commits May 31, 2024 18:01
@AlexAxthelm
update lintr sttings
44afcf5
@AlexAxthelm
Remove unused dependency
9c0a60f
@AlexAxthelm
Add sysdeps
e093020
@AlexAxthelm
Allow test script to read PARAMs
3071094
@AlexAxthelm
Move file
213a10a
@AlexAxthelm
simplify default params
d32cfeb
@AlexAxthelm
Move params to config
af887c5
@AlexAxthelm
Remove unneded class assignment
098109d
@AlexAxthelm
Fix call to real estate dir
8d7fba4
@AlexAxthelm
Add more bind mounts
d632575
@AlexAxthelm
Fix bad path in test suite
16fb696
@AlexAxthelm
Explicitly no validation yet
d3ecd91
@AlexAxthelm
Add inheritance parameters
c1c5e73
@AlexAxthelm
Disable test
928afe2
@AlexAxthelm
Fix output paths in test
9bcdc6a
@AlexAxthelm
Use main branch for dependency
ed70eac 
RMI-PACTA/pacta.portfolio.report#78 is merged
@AlexAxthelm
Move start_year param to year-specific files
0b711fa
@AlexAxthelm
Quic update for readme
6f73ddb
@AlexAxthelm @cjyetman
Apply suggestions from code review
ef3c845 
Co-authored-by: CJ Yetman <cj@cjyetman.com>
@AlexAxthelm
reindent block
2ee3547
@AlexAxthelm
Fix docker label
15f0ba4
@AlexAxthelm
Update error string
e778ffc
@AlexAxthelm AlexAxthelm self-assigned this Jun 11, 2024
@github-actions GitHub Actions
Copy link

Docker build status

commit_time git_sha image
2024-06-11T10:30:19Z e778ffc ghcr.io/rmi-pacta/workflow.pacta.report:pr-21

@github-actions GitHub Actions
Copy link

Report Links

commit_time git_sha config report summary image
2024-06-11T10:30:19Z e778ffc default_2022Q4 Report Summary ghcr.io/rmi-pacta/workflow.pacta.report:pr-21
2024-06-11T10:30:19Z e778ffc default_2023Q4 Report Summary ghcr.io/rmi-pacta/workflow.pacta.report:pr-21

jdhoffa
jdhoffa approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamping as I already reviewed #17 in detail

@AlexAxthelm AlexAxthelm merged commit fc1aa1e into main Jun 11, 2024
46 checks passed
@AlexAxthelm AlexAxthelm deleted the refactor/11-convert-to-package branch June 11, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhoffa jdhoffa jdhoffa approved these changes

@cjyetman cjyetman Awaiting requested review from cjyetman

Assignees

@AlexAxthelm AlexAxthelm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexAxthelm @jdhoffa