Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outdated packages in package.json #463

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

Aditys018
Copy link
Contributor

Date: 09-10-2024

Developer Name: Aditi Shinde


Issue Ticket Number

#454

Description

This Updates the following packages from the package.json

• async-storage • netinfo • masked-view • axios • prettier • app-auth • tab-view • image-picker • keychain • buttons-group • safe-area-context • react-native-svg • react-redux • align-deps • jest-native • jest • react • react-native • eslint-parser • eslint

Additionally updated DatePicker.tsx for compatibility with the updated dependencies (Refs: #462 )

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1
RDS_Test1.mp4

Test Coverage

Screenshot 1 NA

Additional Notes

Copy link
Contributor

@ashifkhn ashifkhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you changed minSdkVersion?

Copy link

@Ayushsanjdev Ayushsanjdev Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, This will lead to having issues on publishing it to playstore, should always use latest. @Aditys018 fyi

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this change needed?

src/components/CreateGoalForm/DatePicker.tsx Outdated Show resolved Hide resolved
Copy link

@Ayushsanjdev Ayushsanjdev Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, This will lead to having issues on publishing it to playstore, should always use latest. @Aditys018 fyi

@Aditys018 Aditys018 changed the title fix(deps): update packages and modify Datepicker.tsx, Refs: #454,462 fix(deps): update outdated packages in package.json Oct 9, 2024
@Aditys018 Aditys018 changed the title fix(deps): update outdated packages in package.json Update outdated packages in package.json Oct 11, 2024
pankajjs and others added 5 commits October 15, 2024 23:57
* fix: tests

* refactor: remove skip test

* fix: test
- remove skip from test
- added mock to test navigation

* fix: changed expected value

* fix: restore all mocks after each test
Co-authored-by: Ashif Khan <54736284+ashifkhn@users.noreply.github.com>
* fix(skipped testcase): remove skipped testcases and updated testcases for utils

* test: removed skip from testcases in util tests

* test: updated mock api error message
* fix: delete unused file & package DatePicker.tsx

* Updated Yarn.lock

* Reverted files

* Updated Yarn.lock

* Reverted files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants