generated from Real-Dev-Squad/website-template
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update outdated packages in package.json #463
Open
Aditys018
wants to merge
10
commits into
Real-Dev-Squad:develop
Choose a base branch
from
Aditys018:fix/update-outdated-packages
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+286
−203
Open
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e6bd2d0
fix(deps): update packages and modify Datepicker.tsx, Refs: #454,462
Aditys018 7e4a55a
Fix:GradleVersion,jvmargs
Aditys018 72c6e40
fix: delete unused file & package DatePicker.tsx
Aditys018 ca5b408
Rebase branches & update outdated packages #454
Aditys018 a0737dc
Rebase branches & updated outdated packages #454
Aditys018 04bd7d1
Fix broken tests for todo component (#466)
pankajjs d3bb939
fix: type error in AuthScreen.tsx (#465)
surajmaity1 467121c
Fix/remove skipped test cases (#472)
abhisheksharmayt bfd515a
Delete unused file & package DatePicker.tsx (#467)
Aditys018 a61fa6c
Merge branch 'fix/update-outdated-packages' of https://github.com/Adi…
Aditys018 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why was this change needed? |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aditys018 marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,58 +1,58 @@ | ||
import React, { useState } from 'react'; | ||
import { SafeAreaView, StyleSheet, View } from 'react-native'; | ||
import DatePicker from 'react-native-datepicker'; | ||
// import React, { useState } from 'react'; | ||
shreya-mishra marked this conversation as resolved.
Show resolved
Hide resolved
|
||
// import { SafeAreaView, StyleSheet, View } from 'react-native'; | ||
// import DatePicker from 'react-native-datepicker'; | ||
|
||
const DatePickerComponent = () => { | ||
const [date, setDate] = useState(''); | ||
// const DatePickerComponent = () => { | ||
// const [date, setDate] = useState(''); | ||
|
||
return ( | ||
<SafeAreaView style={styles.container}> | ||
<View style={styles.container}> | ||
<DatePicker | ||
style={styles.datePickerStyle} | ||
date={date} | ||
mode="date" | ||
placeholder="DD-MM-YYYY" | ||
format="DD-MM-YYYY" | ||
minDate="01-01-2020" | ||
maxDate="01-01-2025" | ||
confirmBtnText="Confirm" | ||
cancelBtnText="Cancel" | ||
customStyles={{ | ||
dateIcon: { | ||
position: 'absolute', | ||
left: 0, | ||
top: 4, | ||
marginLeft: 0, | ||
}, | ||
dateInput: { | ||
marginLeft: 36, | ||
height: 30, | ||
border: 'none', | ||
}, | ||
}} | ||
onDateChange={() => { | ||
setDate(date); | ||
}} | ||
/> | ||
</View> | ||
</SafeAreaView> | ||
); | ||
}; | ||
// return ( | ||
// <SafeAreaView style={styles.container}> | ||
// <View style={styles.container}> | ||
// <DatePicker | ||
// style={styles.datePickerStyle} | ||
// date={date} | ||
// mode="date" | ||
// placeholder="DD-MM-YYYY" | ||
// format="DD-MM-YYYY" | ||
// minDate="01-01-2020" | ||
// maxDate="01-01-2025" | ||
// confirmBtnText="Confirm" | ||
// cancelBtnText="Cancel" | ||
// customStyles={{ | ||
// dateIcon: { | ||
// position: 'absolute', | ||
// left: 0, | ||
// top: 4, | ||
// marginLeft: 0, | ||
// }, | ||
// dateInput: { | ||
// marginLeft: 36, | ||
// height: 30, | ||
// border: 'none', | ||
// }, | ||
// }} | ||
// onDateChange={() => { | ||
// setDate(date); | ||
// }} | ||
// /> | ||
// </View> | ||
// </SafeAreaView> | ||
// ); | ||
// }; | ||
|
||
export default DatePickerComponent; | ||
// export default DatePickerComponent; | ||
|
||
const styles = StyleSheet.create({ | ||
container: { | ||
flex: 1, | ||
padding: 8, | ||
justifyContent: 'center', | ||
alignItems: 'center', | ||
}, | ||
datePickerStyle: { | ||
height: 40, | ||
border: '1px solid black', | ||
width: 205, | ||
marginTop: 2, | ||
}, | ||
}); | ||
// const styles = StyleSheet.create({ | ||
// container: { | ||
// flex: 1, | ||
// padding: 8, | ||
// justifyContent: 'center', | ||
// alignItems: 'center', | ||
// }, | ||
// datePickerStyle: { | ||
// height: 40, | ||
// border: '1px solid black', | ||
// width: 205, | ||
// marginTop: 2, | ||
// }, | ||
// }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have you changed minSdkVersion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, This will lead to having issues on publishing it to playstore, should always use latest. @Aditys018 fyi