feat: add navbar component #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
satyam73
changed the title
sahsisunny
reviewed
Feb 27, 2024
sahsisunny
reviewed
Feb 27, 2024
satyam73
commented
Feb 27, 2024
sahsisunny
reviewed
Feb 27, 2024
|
In the video the navbar disappears after sign in, didn't get that. |
It redirected to staging-skilltree.realdevsquad.com since I haven't changed in my dev environment env file while making video, this isn't a problem and will work accordingly in different environments. As of now I haven't added name and profile picture in navbar, this will be handled separately in next PR. |
sahsisunny
previously approved these changes
Feb 28, 2024
ajoykumardas12
previously approved these changes
Feb 28, 2024
satyam73
dismissed stale reviews from VinayakaHegade, ajoykumardas12, and sahsisunny
via
64a8a50
ajoykumardas12
previously approved these changes
Feb 28, 2024
VinayakaHegade
previously approved these changes
Feb 28, 2024
sahsisunny
previously approved these changes
Feb 28, 2024
Achintya-Chatterjee
previously approved these changes
Feb 29, 2024
Tests/navbar
satyam73
dismissed stale reviews from Achintya-Chatterjee, sahsisunny, VinayakaHegade, and ajoykumardas12
via
5abec12
Achintya-Chatterjee
approved these changes
Feb 29, 2024
satyam73
changed the title
VinayakaHegade
approved these changes
Mar 1, 2024
ajoykumardas12
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 25-02-2024
Developer Name: Satyam Bajpai
Issue Ticket Number
Description
Created a navbar component.
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
skill-tree-navbar-feature.mp4
Test Coverage
Additional Notes