feat: docker setup for development environment #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| target: final | ||
| tiny_site_backend: | ||
| container_name: tiny_site_backend | ||
| image: realdevsquad/tiny_site_backend:1.0.0 |
There was a problem hiding this comment.
Why are we getting the image from dokcer hub?
We should be building the image on user system it seld
Comment on lines
+21
to
+23
| POSTGRES_PASSWORD: postgres | ||
| POSTGRES_USER: postgres | ||
| POSTGRES_DB: postgres |
There was a problem hiding this comment.
Why did we change this? any reason
Comment on lines
+29
to
+30
| volumes: | ||
| pgdata: {} |
There was a problem hiding this comment.
We should add volume mapping, so that the DB data is persisted
|
Does this support hot reload? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Ticket Number
Description
Added docker setup for development environments
Breaking Changes
If your feature introduces breaking changes or if something is missing, please mention the related issue tickets.
Development Tested?
Confirm whether the changes have been tested locally during development.
Tested in Staging?
Indicate whether the changes have been tested in the staging environment for dev to main.
Database Changes