Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: docker setup for development environment #79

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 24 additions & 45 deletions docker-compose.yaml
Original file line number Diff line number Diff line change
@@ -1,51 +1,30 @@
# Comments are provided throughout this file to help you get started.
# If you need more help, visit the Docker compose reference guide at
# https://docs.docker.com/compose/compose-file/
version: '3.9'

# Here the instructions define your application as a service called "server".
# This service is built from the Dockerfile in the current directory.
# You can add other services your application may depend on here, such as a
# database or a cache. For examples, see the Awesome Compose repository:
# https://github.com/docker/awesome-compose
services:
server:
build:
context: .
target: final
tiny_site_backend:
container_name: tiny_site_backend
image: realdevsquad/tiny_site_backend:1.0.0
build: .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we getting the image from dokcer hub?
We should be building the image on user system it seld

environment:
# Update all the envs here
DB_URL: 'postgresql://postgres:postgres@localhost:5432/postgres?sslmode=disable'
DB_MAX_OPEN_CONNECTIONS: '5'
ALLOWED_ORIGINS: 'http://localhost:3000'
ports:
- 4001:4001

# The commented out section below is an example of how to define a PostgreSQL
# database that your application can use. `depends_on` tells Docker Compose to
# start the database before your application. The `db-data` volume persists the
# database data between container restarts. The `db-password` secret is used
# to set the database password. You must create `db/password.txt` and add
# a password of your choosing to it before running `docker compose up`.
- '8000:8000'
depends_on:
db:
condition: service_healthy
db:
image: postgres
user: postgres
# secrets:
# - db-password
# volumes:
# - db-data:/var/lib/postgresql/data
- tiny_site_backend_db
tiny_site_backend_db:
container_name: tiny_site_backend_db
image: postgres:12
environment:
- POSTGRES_USER=tinysite
- POSTGRES_DB=tinysite
- POSTGRES_PASSWORD=tinysite
# - POSTGRES_PASSWORD_FILE=/run/secrets/db-password
expose:
- 5432
healthcheck:
test: [ "CMD", "pg_isready" ]
interval: 10s
timeout: 5s
retries: 5
# volumes:
# db-data:
# secrets:
# db-password:
# file: db/password.txt
POSTGRES_PASSWORD: postgres
POSTGRES_USER: postgres
POSTGRES_DB: postgres
ports:
Comment on lines +21 to +23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we change this? any reason

- '5432:5432'
volumes:
- pgdata:/var/lib/postgresql/data

volumes:
pgdata: {}
Loading