-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add task request UI #402
Conversation
Deploying with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good but some minor changes are required.
- Create the Separate constant file for the constant value.
- Create variable for the RGB and HEX value of the color in CSS.
- Use already written utils function if possible.
- Give the proper name to the variable.
- Remove the console.log from the code.
- Move the utils function to the separate file.
Use variables for colors Use constants for messages Extract constants into a separate file
Use console.error in catch statement Avoid unexpected error due to undefined value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please write tests for this change.
Tests contain a lots of changes which is why they are being held in a separate PR #407 |
remove !important flag in css
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
feat: Add task request details page
e015ed4
…est-details Revert "feat: Add task request details page"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://jam.dev/c/273db6f0-6a47-4aa0-bb94-8c87aaaefce8
Check this out it always says that i am not authenticated to view this page even though i am super user in staging.
using the above link you can see my network and console logs
@RitikJaiswal75 can you please tell me what causing this error |
|
Most probably its the backend api, in the given link you can see the exact state of my network calls and console. |
@RitikJaiswal75 I have raised a new PR and also tagged you for review. Can you please check that, you can also check whether the problem is still there or not. If it's there also I will connect with you tonight to discuss. Thank You |
This PR is moved to new PR #460 |
closes #275
This PR is following stacked PR pattern. The PR above it are
PR for tests
Desktop View
Show
Mobile View
Show
Show