feat: Add task request details page #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
8388200
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://86cac53c.dashboard-rds.pages.dev |
| Branch Preview URL: | https://feat-task-request-details.dashboard-rds.pages.dev |
TanishqSingla
force-pushed
the
feat/task-request-details
branch
from
fa223c5
to
338204f
Compare
kotesh-arya
reviewed
Jul 15, 2023
kotesh-arya
reviewed
Jul 15, 2023
bharati-21
reviewed
Jul 15, 2023
taskRequests/details/script.js
Outdated
| taskSkeleton.classList.add('hidden'); | ||
| const data = await res.json(); | ||
|
|
||
| const { taskData } = data; |
There was a problem hiding this comment.
The taskData should be initialised with an {} so that we can avoid undefined errors
There was a problem hiding this comment.
addressed, pls check
bharati-21
reviewed
Jul 15, 2023
taskRequests/details/script.js
Outdated
| }), | ||
| ); | ||
| } catch (e) { | ||
| console.log(e); |
bharati-21
reviewed
Jul 15, 2023
TanishqSingla
force-pushed
the
feat/task-request-details
branch
from
63a2ede
to
2eff3ef
Compare
sahsisunny
previously approved these changes
Jul 15, 2023
Use console.error in catch statement Avoid unexpected error due to undefined value
TanishqSingla
force-pushed
the
feat/task-request-details
branch
from
2eff3ef
to
8d33633
Compare
sahsisunny
approved these changes
Jul 15, 2023
|
PR for tests: #407 |
RitikJaiswal75
previously approved these changes
Jul 19, 2023
bharati-21
suggested changes
Jul 20, 2023
iamitprakash
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is a part of stacked PR pattern, The PR below it are:
Tests PR
Desktop view
status waiting
Show
status approved
Show
Show
Mobile View
status approved
Show
status waiting
Show
loading
Show