-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/repository links for webpages #863
Feature/repository links for webpages #863
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed 01-10-2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please write the test and why there is both package lock and yarn lock ?
61a4b64
to
2c52438
Compare
The footer is not aligned at applications and discord group page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix the build on CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the footer to a different file/folder and import it at every other place where it is used? As you are repeating same HTML several times
…b.com/shantanu-02/RDS-website-dashboard into feature/repository-links-for-webpages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After my last review why there too much file changed?
also update the screen shot from the pr
Beacuse previously there were pages which had footer...but only 3 files didn't had any...so my task ws to add fotter to those pages only...That's why asked you before making reusable component...since I made the footer component I replaced that component with previously written footers |
Done with the new screenshots. |
So for now update only the 3 files for rest of the file create another pr |
Done with the changes please review. |
…b.com/shantanu-02/RDS-website-dashboard into feature/repository-links-for-webpages
Can you add more screenshots with different screen size also fix the failing test |
…b.com/shantanu-02/RDS-website-dashboard into feature/repository-links-for-webpages
Date: 29/09/2024
Developer Name: shantanu-pawar-1
Issue Ticket Number
Description
On the Dashboard site of RDS, where links to various web pages are present at the bottom of each web page add the repository link of respective web page.
Under Feature Flag
Database Changes
Development Tested?
Screenshots