Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TODOs from BZSyncManager #849

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Remove TODOs from BZSyncManager #849

merged 1 commit into from
Dec 4, 2024

Conversation

MrMarble
Copy link
Member

@MrMarble MrMarble commented Dec 3, 2024 •
edited
Loading

As discussed on today's stand-up, I've removed the TODOs on BZSyncManager class and added a small comment to state why the custom schedule implementation is needed

Closes OSIDB-3205

@MrMarble MrMarble requested a review from a team December 3, 2024 17:17
@MrMarble MrMarble self-assigned this Dec 3, 2024
@MrMarble MrMarble added the technical For PRs that introduce changes not worthy of a CHANGELOG entry label Dec 3, 2024
osoukup
osoukup approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@osoukup osoukup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrMarble MrMarble added this pull request to the merge queue Dec 4, 2024
Merged via the queue into master with commit 8c14f75 Dec 4, 2024
13 checks passed
@MrMarble MrMarble deleted the OSIDB-3205 branch December 4, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osoukup osoukup osoukup approved these changes

Assignees

@MrMarble MrMarble

Labels
technical For PRs that introduce changes not worthy of a CHANGELOG entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrMarble @osoukup