Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TODOs from BZSyncManager #849

Merged
merged 1 commit into from
Dec 4, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions osidb/sync_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -547,20 +547,9 @@ def schedule(cls, sync_id, *args, **kwargs):
"""
Schedule BZSyncManager's sync_task to Celery queue.

TODO:
- This is a workaround. SyncManager.schedule should not
decide to skip or postpone tasks, but we need it to:
- Reduce noise in flower logs that would be generated
by duplicate tasks failing.
- Reduce amount of requests sent needlessly to Bugzilla.
- Avoid sending potentially incomplete data immediately.
- Move the deduplication logic to Flaw.bzsync:
- No BZSyncManager-related action upon client request.
- A periodic task to query recently changed tasks once per
X minutes and call BZSyncManager.schedule for them.
- BZSyncManager.schedule to be left not implemented,
inherited SyncManager.schedule used.
- OSIDB-3205
This implementation uses custom de-duplication logic
and a 20 seconds delay to mitigate "outdated model" conflicts on bugzilla.
See OSIDB-3205 for more details.

:param sync_id: Unique ID for synchronized data object.
"""
Expand Down
Loading