Convert server status endpoint to ninja #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
force-pushed
the
convert-status-endpoint-to-ninja
branch
from
dff0702
to
6333542
Compare
mvandenburgh
force-pushed
the
convert-status-endpoint-to-ninja
branch
3 times, most recently
from
4fe7896
to
626b211
Compare
mvandenburgh
force-pushed
the
convert-status-endpoint-to-ninja
branch
from
626b211
to
12ef4e6
Compare
mvandenburgh
commented
Aug 22, 2023
Comment on lines
+19
to
+21
| @staticmethod | ||
| def resolve_iso8601(obj: datetime.timedelta): | ||
| return str(obj) |
There was a problem hiding this comment.
Note, this returns a slightly different string than the DRF serializer for datetime.timedelta. Previously, the return value would look something like 6 05:04:40.740791, but now it is 6 days, 05:04:40.740791.
There was a problem hiding this comment.
In testing, I'm getting back an iso8601 duration format: "iso8601": "P0DT00H03M56.226221S" which I think is fine.
|
@BryonLewis with #243 being merged, this is now the last Ninja conversion. I'll make a follow up PR to this that removes the remaining bits of DRF (mostly DRF exceptions still being used). |
BryonLewis
approved these changes
Aug 23, 2023
Comment on lines
+19
to
+21
| @staticmethod | ||
| def resolve_iso8601(obj: datetime.timedelta): | ||
| return str(obj) |
There was a problem hiding this comment.
In testing, I'm getting back an iso8601 duration format: "iso8601": "P0DT00H03M56.226221S" which I think is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.