Gesturefy v4 (Port to manifest v3) #715
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox will provide global user controls for site access per add-on. See: - https://bugzilla.mozilla.org/show_bug.cgi?id=1497075 - https://bugzilla.mozilla.org/show_bug.cgi?id=1711787 Removing this option from Gesturefy reduces the amount of code that needs to be maintained. It's also more performant to exclude the entire content script from running than doing content script side checks. Last but not least exclusions have always been a power feature that never really fit into Gesturefy from a design/UI standpoint. Also resolves #542
The reason behind this change is that content scripts no longer get access to extension files unless they are declared as a web_accessible_resource. I'm against doing so for privacy reasons. At least in theory websites could use web_accessible_resource for fingerprinting. Some additional information can be found here: https://bugzilla.mozilla.org/show_bug.cgi?id=1578405
Previously all unmatching gestures were hidden including the "new gesture button". This could lead to confusion that gestures are missing/disappeared and no new gestures can be added. The new concept only unhighlights unmatching gestures which still provides an overview over all gestures, indicates that some sort of filtering is active and allows adding new gestures. The only downside is that users have to scan the screen (on smaller screens even need to scroll) in order to find the results.
Historical moment. I hope you're all proud of me, that these actions finally leave the "about" page.
Also add the ability to backup/restore the config to/from the cloud
It now works with urls instead of tabs and globs instead of regex The latter ensures backwards compatibility and allows a potential change to the dynamic content script API in the future
So far there is now way to do this via browser functionality, or dynamic content script registration. See also w3c/webextensions#653
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements:
allow disabling Gesturefy for certain websites (https://bugzilla.mozilla.org/show_bug.cgi?id=1497075, https://bugzilla.mozilla.org/show_bug.cgi?id=1711787)This will probably not happen in the near future so we should stick to the existing exclusions.