Added navigation bar component #74

Slartibartfass2 · 2024-11-12T22:38:06Z

Closes #73

github-actions · 2024-11-14T23:16:51Z

LCOV of commit `4420f83` during Code Quality Checks #169

Summary coverage rate:
  lines......: 44.3% (222 of 501 lines)
  functions..: 9.1% (6 of 66 functions)
  branches...: no data found

Files changed coverage rate:
                                                                                |Lines       |Functions  |Branches    
  Filename                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================
  src/lib/components/composites/navigation-bar/NavigationBar.svelte             | 100%     11| 0.0%     1|    -      0
  src/lib/components/composites/navigation-bar/PaperNavigationBar.svelte        | 100%      1| 0.0%     1|    -      0
  src/lib/components/composites/navigation-bar/ProjectNavigationBar.svelte      | 100%     16| 0.0%     1|    -      0
  src/lib/components/composites/navigation-bar/SimpleNavigationBar.svelte       | 100%      2| 0.0%     1|    -      0
  src/lib/components/composites/navigation-bar/UserMenu.svelte                  | 100%     28|50.0%     2|    -      0
  src/lib/components/composites/paper-components/PaperInfo.svelte               | 100%      6| 0.0%     1|    -      0
  src/lib/components/primitives/avatar/avatar-fallback.svelte                   | 100%      5| 0.0%     1|    -      0
  src/lib/components/primitives/avatar/avatar-image.svelte                      | 100%      5| 0.0%     1|    -      0
  src/lib/components/primitives/avatar/avatar.svelte                            | 100%      5| 0.0%     1|    -      0
  src/lib/components/primitives/avatar/index.ts                                 | 100%      1| 0.0%     1|    -      0
  src/lib/components/primitives/card/card-content.svelte                        | 100%      4| 0.0%     1|    -      0
  src/lib/components/primitives/card/card-description.svelte                    | 100%      4| 0.0%     1|    -      0
  src/lib/components/primitives/card/card-footer.svelte                         | 100%      4| 0.0%     1|    -      0
  src/lib/components/primitives/card/card-header.svelte                         | 100%      4| 0.0%     1|    -      0
  src/lib/components/primitives/card/card-title.svelte                          | 100%      8| 0.0%     1|    -      0
  src/lib/components/primitives/card/card.svelte                                | 100%      6| 0.0%     1|    -      0
  src/lib/components/primitives/card/index.ts                                   | 100%      1| 0.0%     1|    -      0
  src/lib/components/primitives/dropdown-menu/dropdown-menu-checkbox-item.svelte| 100%     11| 0.0%     1|    -      0
  src/lib/components/primitives/dropdown-menu/dropdown-menu-content.svelte      | 100%      7| 0.0%     1|    -      0
  src/lib/components/primitives/dropdown-menu/dropdown-menu-group-heading.svelte| 100%      5| 0.0%     1|    -      0
  src/lib/components/primitives/dropdown-menu/dropdown-menu-item.svelte         | 100%      7| 0.0%     1|    -      0
  src/lib/components/primitives/dropdown-menu/dropdown-menu-label.svelte        | 100%      6| 0.0%     1|    -      0
  src/lib/components/primitives/dropdown-menu/dropdown-menu-radio-item.svelte   | 100%      9| 0.0%     1|    -      0
  src/lib/components/primitives/dropdown-menu/dropdown-menu-separator.svelte    | 100%      5| 0.0%     1|    -      0
  src/lib/components/primitives/dropdown-menu/dropdown-menu-shortcut.svelte     | 100%      6| 0.0%     1|    -      0
  src/lib/components/primitives/dropdown-menu/dropdown-menu-sub-content.svelte  | 100%      6| 0.0%     1|    -      0
  src/lib/components/primitives/dropdown-menu/dropdown-menu-sub-trigger.svelte  | 100%      7| 0.0%     1|    -      0
  src/lib/components/primitives/dropdown-menu/index.ts                          | 100%      6| 0.0%     1|    -      0
  src/lib/components/primitives/tabs/index.ts                                   | 100%      2| 0.0%     1|    -      0
  src/lib/components/primitives/tabs/tabs-content.svelte                        | 100%      6| 0.0%     1|    -      0
  src/lib/components/primitives/tabs/tabs-list.svelte                           | 100%      6| 0.0%     1|    -      0
  src/lib/components/primitives/tabs/tabs-trigger.svelte                        | 100%      6| 0.0%     1|    -      0
  src/routes/+layout.svelte                                                     | 0.0%      1| 0.0%     1|    -      0
  src/routes/+page.svelte                                                       | 0.0%      4| 0.0%     1|    -      0
  src/routes/archivedprojects/+page.svelte                                      | 0.0%      4| 0.0%     1|    -      0
  src/routes/invitations/+page.svelte                                           | 0.0%      4| 0.0%     1|    -      0
  src/routes/paper/[paperId]/+page.svelte                                       | 0.0%     19| 0.0%     1|    -      0
  src/routes/paper/[paperId]/+page.ts                                           | 0.0%      9| 100%     1|    -      0
  src/routes/project/[projectId]/+layout.ts                                     | 0.0%      9| 100%     1|    -      0
  src/routes/project/[projectId]/dashboard/+page.svelte                         | 0.0%      8| 0.0%     1|    -      0
  src/routes/project/[projectId]/paper/[paperId]/+page.svelte                   | 0.0%     20| 0.0%     1|    -      0
  src/routes/project/[projectId]/paper/[paperId]/+page.ts                       | 0.0%     14| 100%     1|    -      0
  src/routes/project/[projectId]/paper/new/+page.svelte                         | 0.0%     10| 0.0%     1|    -      0
  src/routes/project/[projectId]/papers/+page.svelte                            | 0.0%      8| 0.0%     1|    -      0
  src/routes/project/[projectId]/settings/+layout.svelte                        | 0.0%      8| 0.0%     1|    -      0
  src/routes/project/[projectId]/settings/general/+page.svelte                  | 0.0%      2| 0.0%     1|    -      0
  src/routes/project/[projectId]/settings/members/+page.svelte                  | 0.0%      2| 0.0%     1|    -      0
  src/routes/project/[projectId]/settings/review/+page.svelte                   | 0.0%      2| 0.0%     1|    -      0
  src/routes/project/[projectId]/settings/slr/+page.svelte                      | 0.0%      2| 0.0%     1|    -      0
  src/routes/project/[projectId]/statistics/+page.svelte                        | 0.0%      8| 0.0%     1|    -      0
  src/routes/readinglist/+page.svelte                                           | 0.0%      4| 0.0%     1|    -      0
  src/routes/settings/+layout.svelte                                            | 0.0%      4| 0.0%     1|    -      0

luca-schlecker · 2024-11-18T11:27:33Z

The floating bar seems a little large to me. What are your thoughts on this?

Merseleo

It seems a lot of feedback, but it was also a lot of code, so all in all very good (especially structured ...) and only some suggestions to improve the design.

One thing I noticed in general: I think the semantics of the back button are not correct. I am always redirected to the homepage or project overview and not back to the last page.

Furthermore, I think it would be nice to have some short comments at the beginning of each component, which describes what it is and where it is used.

src/routes/paper/[paperId]/+page.ts

src/routes/project/[projectId]/paper/[paperId]/+page.ts

test/integration/navigation-bar/navigation-bar.test.ts

test/integration/navigation-bar/paper-navigation-bar.test.ts

src/lib/components/composites/navigation-bar/SimpleNavigationBar.svelte

src/lib/components/composites/navigation-bar/NavigationBar.svelte

src/lib/components/composites/navigation-bar/UserMenu.svelte

src/lib/components/primitives/tabs/tabs-list.svelte

src/lib/components/primitives/tabs/tabs-trigger.svelte

Slartibartfass2 · 2024-11-18T23:52:58Z

It seems a lot of feedback, but it was also a lot of code, so all in all very good (especially structured ...) and only some suggestions to improve the design.

One thing I noticed in general: I think the semantics of the back button are not correct. I am always redirected to the homepage or project overview and not back to the last page.

Furthermore, I think it would be nice to have some short comments at the beginning of each component, which describes what it is and where it is used.

Thank you, for taking the time to review this PR!

Let's discuss the navigation again, there are some open questions that have to be answered.

Merseleo

There are only a few small things left, but I'd like to hear your opinion again, otherwise I think we're done.
One last question regarding the back navigation: do you create an issue for this problem or should I or would you like to solve it in this PR?

src/app.d.ts

src/routes/paper/[paperId]/+page.ts

test/integration/navigation-bar/navigation-bar.test.ts

test/integration/navigation-bar/paper-navigation-bar.test.ts

src/lib/components/composites/paper-elements/PaperInfo.svelte

src/lib/components/composites/navigation-bar/UserMenu.svelte

src/lib/components/primitives/tabs/tabs-trigger.svelte

Slartibartfass2

Thanks for your review again!

I'd like to this discuss the back button behavior in person.

src/app.d.ts

test/integration/navigation-bar/paper-navigation-bar.test.ts

src/lib/components/composites/paper-elements/PaperInfo.svelte

src/lib/components/composites/navigation-bar/UserMenu.svelte

src/lib/components/primitives/tabs/tabs-trigger.svelte

…es to /components/composites

…element

This makes the navigation bar component less clustered

Merseleo

I think we are finally done with it ...

Slartibartfass2 self-assigned this Nov 12, 2024

Slartibartfass2 linked an issue Nov 12, 2024 that may be closed by this pull request

[Feature]: Add Tool Dock/Floating Navigation Bar component #73

Closed

Slartibartfass2 force-pushed the feat/73-feature-add-tool-dockfloating-navigation-bar-component branch from caf4ce1 to 7903464 Compare November 14, 2024 14:02

Slartibartfass2 marked this pull request as ready for review November 14, 2024 14:35

Slartibartfass2 marked this pull request as draft November 14, 2024 14:35

Slartibartfass2 force-pushed the feat/73-feature-add-tool-dockfloating-navigation-bar-component branch 2 times, most recently from 5fc7159 to 1b950dc Compare November 14, 2024 23:15

Slartibartfass2 force-pushed the feat/73-feature-add-tool-dockfloating-navigation-bar-component branch 3 times, most recently from 7f6b45e to 3795730 Compare November 15, 2024 23:30

Slartibartfass2 mentioned this pull request Nov 16, 2024

Added test reporters and coverage analysis #69

Merged

Slartibartfass2 force-pushed the feat/73-feature-add-tool-dockfloating-navigation-bar-component branch 2 times, most recently from 5bfb2b0 to fd5587b Compare November 17, 2024 01:13

Slartibartfass2 requested a review from Merseleo November 17, 2024 01:14

Slartibartfass2 marked this pull request as ready for review November 17, 2024 01:14

Slartibartfass2 force-pushed the feat/73-feature-add-tool-dockfloating-navigation-bar-component branch from fd5587b to 48e69e0 Compare November 18, 2024 08:39

Slartibartfass2 force-pushed the feat/73-feature-add-tool-dockfloating-navigation-bar-component branch from 48e69e0 to 9bc1c82 Compare November 18, 2024 14:45

Merseleo reviewed Nov 18, 2024

View reviewed changes

Slartibartfass2 force-pushed the feat/73-feature-add-tool-dockfloating-navigation-bar-component branch from 9bc1c82 to 3fe71af Compare November 18, 2024 21:45

Slartibartfass2 force-pushed the feat/73-feature-add-tool-dockfloating-navigation-bar-component branch from bb1b087 to abd9e31 Compare November 19, 2024 09:03

Merseleo reviewed Nov 19, 2024

View reviewed changes

Slartibartfass2 commented Nov 19, 2024

View reviewed changes

Slartibartfass2 added 5 commits November 19, 2024 12:00

feat: added card component

4f8e4a1

feat: added avatar component

a6aaaff

feat: added dropdown menu component

c29a2ba

feat: added tabs component

f1c02d2

feat: added navigation bar component

fff0bc5

Slartibartfass2 added 20 commits November 19, 2024 12:00

feat: added navigation bar to pages

7de7b6d

refactor: used interface for navigation bar props

16fbf75

feat: added simple navigation bar for bars with only a single title

884de98

chore: moved shadcn primitives to /components/primitives and composit…

4185a87

…es to /components/composites

feat: added paper navigation bar

88fce1a

feat: added styles to primitives

15d5f9c

feat: wrapped navigation bar in header and back button + tabs in nav …

992af36

…element

feat: added paper navigation bar to paper create page

f0a6743

feat: children of navigation bar can also be undefined

45a2e1e

test: added integration test for navigation bar

4d0efe8

feat: change type of projectId to number

312a938

test: added integration test for paper navigation bar

7b86fb0

test: added integration test for project navigation bar

9cf7be3

feat: set all props directly instead of default values

c933259

test: added integration test for simple navigation bar

b5b2dec

refactor: move drop down menu to separate component

cb1a06f

This makes the navigation bar component less clustered

feat: change navigation bar style

a0d94f3

feat: add common interfaces and strongly type defaultTabValue

78ff264

test: remove duplicate tests and add another

f0cb8fc

feat: use correct properties for paper interface

c8ec78c

Slartibartfass2 force-pushed the feat/73-feature-add-tool-dockfloating-navigation-bar-component branch from abd9e31 to 1a09784 Compare November 19, 2024 11:00

Slartibartfass2 added 2 commits November 19, 2024 12:57

feat: when author list is empty 'unknown authors' is shown

9634ac5

feat: changed style of tabs

4420f83

Slartibartfass2 force-pushed the feat/73-feature-add-tool-dockfloating-navigation-bar-component branch from 1a09784 to 4420f83 Compare November 19, 2024 11:57

Slartibartfass2 requested a review from Merseleo November 19, 2024 11:59

Merseleo approved these changes Nov 19, 2024

View reviewed changes

Slartibartfass2 merged commit 3b80a1c into develop Nov 19, 2024
7 checks passed

Slartibartfass2 deleted the feat/73-feature-add-tool-dockfloating-navigation-bar-component branch November 19, 2024 12:00

Slartibartfass2 mentioned this pull request Nov 20, 2024

[Use Case]: Navigate Pages #97

Open

Merseleo mentioned this pull request Nov 22, 2024

[Feature]: Add Paper Entry component #101

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added navigation bar component #74

Added navigation bar component #74

Slartibartfass2 commented Nov 12, 2024

github-actions bot commented Nov 14, 2024 •

edited

Loading

luca-schlecker commented Nov 18, 2024

Merseleo left a comment

Slartibartfass2 commented Nov 18, 2024

Merseleo left a comment

Slartibartfass2 left a comment

Merseleo left a comment

Added navigation bar component #74

Added navigation bar component #74

Conversation

Slartibartfass2 commented Nov 12, 2024

github-actions bot commented Nov 14, 2024 • edited Loading

LCOV of commit 4420f83 during Code Quality Checks #169

luca-schlecker commented Nov 18, 2024

Merseleo left a comment

Choose a reason for hiding this comment

Slartibartfass2 commented Nov 18, 2024

Merseleo left a comment

Choose a reason for hiding this comment

Slartibartfass2 left a comment

Choose a reason for hiding this comment

Merseleo left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 14, 2024 •

edited

Loading

LCOV of commit `4420f83` during Code Quality Checks #169