Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC progress #134

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

PoC progress #134

wants to merge 6 commits into from

Conversation

ghandic
Copy link

@ghandic ghandic commented Apr 3, 2024

Summary

The intent of this validation library is to provide input level validations on the client side. We aim to ensure 100% compatibility with the govalidator package and if it is not possible to validate effectively on the frontend for some of the validations/replacements then it should be captured by the backend validation.

Backend validation has a primary objective of creating a secure and reliable system
Frontend validation is used to provide the users immediate feedback where possible and to aid by centralizing the validation logic to the proto specification. Thereby also increasing the developer experience.

Problem description

Pros/cons of approach implemented

Checklist

  • Is this PR a reasonable size?
  • List deployment sequence with all relevant PRs.
    • ...

Code Review Guidelines for Reviewers

  • Try to review in a timely manner. Opinions/nitpicks should not be blockers. Pair on a call for non-trivial feedback.
  • Overall design and approach should follow established patterns. Don't try to make the PR perfect.
  • Try to identify edge cases, race conditions, over-engineering, lack of test coverage and complexity.
  • If you don't feel qualified to review the code, pass it on to someone who is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant