Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IBCDPE-935] private worker pool module #12

Merged
merged 17 commits into from
Jul 25, 2024

Conversation

BryanFauble
Copy link
Contributor

Problem:

  1. I wanted to take a little time and explore this enterprise feature while we had trial access. Private workers allow us to use drift detection for spacelift stacks.

Solution:

  1. I created a terraform module for us to use that deploys private workers to a k8s cluster. I added notes in the readme about it as well so we can pick it up again in the future if we want to use this feature.

Testing:

  1. I was able to deploy the private workers and turn on drift detection. See #dpe-topics slack channel.

@BryanFauble BryanFauble requested a review from a team as a code owner July 18, 2024 21:16
Copy link
Contributor

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM! Just a small comment in the code

space_id = "root"
}


resource "spacelift_policy" "drift-detection-warning" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't have the premium policy , does this work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defining policies in this file just makes them available to be used. It does not add it to any stacks.

If this policy were added to a stack it would always pass because of the condition in .rego file:
input.spacelift.run.drift_detection

drift_detection would always not exist or be false in all cases.

Since I had already written this I was just going to leave it in.

@BryanFauble BryanFauble merged commit 7da2f45 into main Jul 25, 2024
3 of 5 checks passed
@BryanFauble BryanFauble deleted the ibcdpe-935-private-worker-pool branch July 25, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants