-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IBCDPE-935] private worker pool module #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 LGTM! Just a small comment in the code
space_id = "root" | ||
} | ||
|
||
|
||
resource "spacelift_policy" "drift-detection-warning" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't have the premium policy , does this work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Defining policies in this file just makes them available to be used. It does not add it to any stacks.
If this policy were added to a stack it would always pass because of the condition in .rego
file:
input.spacelift.run.drift_detection
drift_detection
would always not exist or be false in all cases.
Since I had already written this I was just going to leave it in.
Problem:
Solution:
Testing: