[IBCDPE-935] VPC Updates & VPC CNI Exploration #13
Conversation
…oviders themselves
spacelift-int-sagebionetworks
bot
temporarily deployed
to
spacelift/root-spacelift-administrative-stack
| @@ -13,6 +13,11 @@ variable "node_security_group_id" { | |||
| type = string | |||
| } | |||
|
|
|||
| variable "pod_to_node_dns_sg_id" { | |||
There was a problem hiding this comment.
Should we have a default for this variable?
There was a problem hiding this comment.
No. We would have no way of knowing what it would be. The way this works is in the spacelift terraform modules you'll see this block:
resource "spacelift_stack_dependency_reference" "pod-to-node-security-group-id-reference" {
stack_dependency_id = spacelift_stack_dependency.k8s-stack-to-deployments.id
output_name = "pod_to_node_dns_sg_id"
input_name = "TF_VAR_pod_to_node_dns_sg_id"
}
This is passing along the output from the k8s infrastructure (Which contains the EKS module) as input to the k8s deployments stack (Which deploys the kubernetes resources).
| stack_id = spacelift_stack.k8s-stack.id | ||
| read = true | ||
| write = true | ||
| } | ||
|
|
||
| resource "spacelift_aws_integration_attachment" "k8s-deployments-aws-integration-attachment" { | ||
| integration_id = "01HXW154N60KJ8NCC93H1VYPNM" | ||
| # org-sagebase-dnt-dev-aws-integration |
| version = "0.3.3" | ||
| vpc_name = "dpe-sandbox" | ||
| capture_flow_logs = true | ||
| flow_log_retention = 1 |
There was a problem hiding this comment.
do we want to increase retention of logs to e.g. 3 days in case we have things running and breaking over the weekends?
There was a problem hiding this comment.
For dev I don't think we will need to. However, yes - We will want to use the retention period that is higher than a day. I'm not sure at this point what that period should be, but it's something I will determine before we move over to prod.
There was a problem hiding this comment.
Word on the street this might be 90 days. Still looking to confirm with IT on this
| variable "cloudwatch_retention" { | ||
| description = "Number of days to retain CloudWatch Logs" | ||
| type = number | ||
| default = 1 |
There was a problem hiding this comment.
Is this enough retention?
There was a problem hiding this comment.
In a later PR I have bumped this to 90
Problem:
Solution:
Testing: