-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCHEMATIC-138] SigNoz cold storage and backups #47
Merged
BryanFauble
merged 136 commits into
signoz-testing
from
schematic-138-cold-storage-and-backups
Nov 21, 2024
Merged
[SCHEMATIC-138] SigNoz cold storage and backups #47
BryanFauble
merged 136 commits into
signoz-testing
from
schematic-138-cold-storage-and-backups
Nov 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanFauble
commented
Nov 6, 2024
BryanFauble
force-pushed
the
schematic-138-cold-storage-and-backups
branch
from
November 6, 2024 23:09
330562c
to
e000497
Compare
spacelift-int-sagebionetworks
bot
temporarily deployed
to
spacelift/brad-sandbox-kubernetes-deployments
November 7, 2024 21:53
Inactive
spacelift-int-sagebionetworks
bot
temporarily deployed
to
spacelift/brad-sandbox-kubernetes-deployments
November 7, 2024 22:12
Inactive
spacelift-int-sagebionetworks
bot
temporarily deployed
to
spacelift/brad-sandbox-kubernetes-deployments
November 7, 2024 22:19
Inactive
spacelift-int-sagebionetworks
bot
temporarily deployed
to
spacelift/brad-sandbox-kubernetes-deployments
November 7, 2024 22:53
Inactive
spacelift-int-sagebionetworks
bot
temporarily deployed
to
spacelift/root-spacelift-administrative-stack
November 20, 2024 19:00
Inactive
spacelift-int-sagebionetworks
bot
temporarily deployed
to
spacelift/dpe-dev-kubernetes-deployments
November 20, 2024 19:39
Inactive
spacelift-int-sagebionetworks
bot
temporarily deployed
to
spacelift/dpe-dev-kubernetes-deployments
November 20, 2024 19:48
Inactive
…#48) * Use scope based authroization on telemetry upload route
BryanFauble
commented
Nov 20, 2024
Comment on lines
+1
to
+6
# global | ||
|
||
installCRDs: true | ||
crds: | ||
# -- Add annotations to all CRD resources, e.g. "helm.sh/resource-policy": keep | ||
annotations: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All default config. I didn't see anything needing to be updated
BWMac
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks again for your help on this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sagebionetworks.jira.com/browse/SCHEMATIC-138
Problem:
Solution:
postRenders
and allows us to inject custom configuration into the rendered helm chart. This is a missing feature from ArgoCD and prevented us from continuing to use that tool.Testing: