Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IBCDPE-939] Correcting some issues #5

Closed
wants to merge 1 commit into from

Conversation

BryanFauble
Copy link
Contributor

Problem:

  1. No instructions were provided on authenticating to the cluster
  2. We were not setting a version on the terraform provider. I set this to the max provided by spacelift. To go beyond this version we'll need to consider using the OpenTofu backend/provider.
  3. We didn't have a CODEOWNERS
  4. Permissions should not have been given as administrator
  5. spotinst has 3 item currently being deployed. From the documentation I can find spotinst/kubernetes-controller/ocean seems like it was a mistake to add this
  6. We had no automatic checking of terraform in the CI pipeline

Solution:

  1. Adding all of the above items

Testing:

  1. Will be checking the terraform plan

@BryanFauble
Copy link
Contributor Author

redo PR once more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant