DRAFT: Split eks creation to own module #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasyu888
approved these changes
Jun 3, 2024
| filter { | ||
| name = "vpc-id" | ||
| values = ["vpc-0f30cfca319ebc521"] | ||
| name = "tag:Name" |
There was a problem hiding this comment.
Thats cool, i didn't realize you could access the tag here
@thomasyu888 For testing I manually created 2 new stacks in Spacelift to deploy this out: The difference between the 2 stacks is that they're pointing to this feature branch and specific project root: In a later PR I will plan to replace our current airflow deployment method with these 2 modules. I'll also want to make an airflow module we can attach to the stacks as well. In addition I'd like to make sure spacelift resources configured by terraform scripts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.