CI improvements #60
CI improvements #60
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
===========================================
- Coverage 100.00% 2.56% -97.44%
===========================================
Files 6 5 -1
Lines 65 39 -26
===========================================
- Hits 65 1 -64
- Misses 0 38 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| version: | ||
| - '1.6' |
There was a problem hiding this comment.
ADTypes is compatible with 1.6 so it needs to be tested on 1.6. There are packages outside of SciML that depend on it and want to support 1.6 (first and foremost DifferentiationInterface). I don't approve this change
|
I think we want to allow the deprecation warnings to pass here. Otherwise, we'd need downstream breaking releases which isn't ideal |
|
There are packages outside of SciML which use ADTypes and want to preserve compatibility with 1.6. Removing it is not okay. Why do you want to activate error on deprecation? We deprecated things on purpose in v1 to allow for a smooth transition @ChrisRackauckas this is a disruptive PR, please don't merge until I'm okay with it |
| @@ -20,7 +20,7 @@ ADTypesEnzymeCoreExt = "EnzymeCore" | |||
| [compat] | |||
| ChainRulesCore = "1.0.2" | |||
| EnzymeCore = "0.5.3,0.6,0.7" | |||
| julia = "1.6" | |||
| @@ -52,13 +52,11 @@ end | |||
| ## Tests | |||
|
|
|||
| @testset verbose=true "ADTypes.jl" begin | |||
| if VERSION >= v"1.10" | |||
There was a problem hiding this comment.
Essential for tests on 1.6 where JET doesn't work
Makes CI more uniform with rest of SciML.
Removes testing for 1.6, since rest of SciML dropped support.
Activates errors on deprecation. Not sure what to do with the tests in the legacy file, since these will now error.