Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI improvements #60

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 21 additions & 16 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
@@ -1,42 +1,47 @@
name: CI
on:
pull_request:
branches:
- main
paths-ignore:
- 'docs/**'
push:
branches:
- main
tags: ['*']
pull_request:
concurrency:
# Skip intermediate builds: always.
# Cancel intermediate builds: only if it is a pull request build.
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{ startsWith(github.ref, 'refs/pull/') }}
paths-ignore:
- 'docs/**'
schedule:
- cron: '53 20 * * 5'
jobs:
test:
name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }}
runs-on: ${{ matrix.os }}
env:
GROUP: ${{ matrix.group }}
strategy:
fail-fast: false
matrix:
group:
- Core
version:
- '1.6'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ADTypes is compatible with 1.6 so it needs to be tested on 1.6. There are packages outside of SciML that depend on it and want to support 1.6 (first and foremost DifferentiationInterface). I don't approve this change

- '1'
os:
- ubuntu-latest
arch:
- x64
- macos-latest
- windows-latest
steps:
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v2
with:
version: ${{ matrix.version }}
arch: ${{ matrix.arch }}
- uses: julia-actions/julia-downgrade-compat@v1
if: ${{ matrix.version == '1.6' }}
with:
skip: Pkg, TOML
- uses: julia-actions/cache@v2
with:
token: ${{ secrets.GITHUB_TOKEN }}
- uses: julia-actions/julia-buildpkg@v1
- uses: julia-actions/julia-runtest@v1
env:
GROUP: ${{ matrix.group }}
with:
depwarn: error
- uses: julia-actions/julia-processcoverage@v1
- uses: codecov/codecov-action@v4
with:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/Documentation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ on:
- main
tags: '*'
pull_request:

schedule:
- cron: '53 20 * * 5'
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{ github.ref_name != github.event.repository.default_branch || github.ref != 'refs/tags/v*' }}
Expand Down
45 changes: 45 additions & 0 deletions .github/workflows/Downgrade.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
name: Downgrade
on:
pull_request:
branches:
- main
paths-ignore:
- 'docs/**'
push:
branches:
- main
paths-ignore:
- 'docs/**'
schedule:
- cron: '53 20 * * 5'
jobs:
test:
runs-on: ${{ matrix.os }}
env:
GROUP: ${{ matrix.group }}
strategy:
fail-fast: false
matrix:
group:
- Core
version:
- '1'
os:
- ubuntu-latest
- macos-latest
- windows-latest
steps:
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v2
with:
version: ${{ matrix.version }}
- uses: julia-actions/julia-downgrade-compat@v1
with:
skip: Pkg,TOML
- uses: julia-actions/cache@v2
with:
token: ${{ secrets.GITHUB_TOKEN }}
- uses: julia-actions/julia-buildpkg@v1
- uses: julia-actions/julia-runtest@v1
env:
GROUP: ${{ matrix.group }}
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ ADTypesEnzymeCoreExt = "EnzymeCore"
[compat]
ChainRulesCore = "1.0.2"
EnzymeCore = "0.5.3,0.6,0.7"
julia = "1.6"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need 1.6 support

julia = "1.10"

[extras]
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
Expand Down
12 changes: 5 additions & 7 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,11 @@ end
## Tests

@testset verbose=true "ADTypes.jl" begin
if VERSION >= v"1.10"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essential for tests on 1.6 where JET doesn't work

@testset "Aqua.jl" begin
Aqua.test_all(ADTypes; deps_compat = (check_extras = false,))
end
@testset "JET.jl" begin
JET.test_package(ADTypes, target_defined_modules = true)
end
@testset "Aqua.jl" begin
Aqua.test_all(ADTypes; deps_compat = (check_extras = false,))
end
@testset "JET.jl" begin
JET.test_package(ADTypes, target_defined_modules = true)
end
@testset "Dense" begin
include("dense.jl")
Expand Down
Loading