Chore/change resourcemap index #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitnayan
requested review from
makeavish,
nityanandagohain,
prashant-shahi and
srikanthccv
as code owners
|
Merge #367 before merging this |
srikanthccv
reviewed
Aug 20, 2024
migrationmanager/migrators/traces/migrations/000031_change_resource_index.up.sql
Outdated
Show resolved
Hide resolved
… schema migrator later
srikanthccv
approved these changes
Aug 28, 2024
this is not a blocker. The sequencing of migration files look fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the type of index for resource attributes from
bloom_filtertotokenbf_v1for keys andngrambf_v1for values. This is tested and implemented in logs already.