-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add index on traceID #367
base: main
Are you sure you want to change the base?
Conversation
this did not work in reducing granules scanned. Needs further investigation |
try using bloom filter instead of tokenbf? also increase the size of the filter |
Can you suggest the size to use? |
@nityanandagohain please suggest the size. The #365 is waiting on this which will help in PRs like SigNoz/signoz#3184 |
If a granule has around 4000 unique trace_id ( 8192 total rows), The size of index = 10KB with 5 hash functions will give us probability of false positive 0.000314144 (1 in 3183). https://hur.st/bloomfilter/?n=4000&p=&m=90000&k=5 let's start with 10KB and 5 hash functions ? |
this PR can wait |
adding index on traceID should enable searching by traceID much faster