Create CI workflows

[IanTapply22]

Description

Created a lint workflow to check any format errors, a format workflow to format any code automatically that's pushed to main, and a build workflow to check if code builds properly without errors. This is linked to #2

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation, if any
• My changes generate no new warnings
• I have performed tests that prove my fix is effective or that my feature works, if necessary
• New and existing unit tests pass locally with my changes

[IanTapply22]

We can fix the failing checks in another PR/issue, so just disregard them for now

[colemacphail]

create ci workflow

fails lint

fails build

💀

[IanTapply22]

create ci workflow

fails lint

fails build

💀

Eh, technically this PR isn't for fixing those errors. It's just to implement the systems to catch them

[IanTapply22]

create ci workflow

fails lint

fails build

💀

#21 Addresses this issue further

[IanTapply22]

Formatting seems to be failing because it isn't on a branch, fixing it now

[colemacphail]

actions/checkout#317 (comment) maybe relevant @IanTapply22

[IanTapply22]

actions/checkout#317 (comment) maybe relevant @IanTapply22

Yep! I'm doing exactly that

[colemacphail]

I think you pass the ref into the checkout action not the format action

[colemacphail]

maybe a silly question but do you have any ideas on why workflows didn't run after the format commit?

[colemacphail]

maybe a silly question but do you have any ideas on why workflows didn't run after the format commit?

like it obviously worked (and we can prob close #22 once this is in) but I think we still need to check that it actually builds once it's formatted properly for when we start enforcing CI to merge

[IanTapply22]

maybe a silly question but do you have any ideas on why workflows didn't run after the format commit?

Well like, I think the google format needs to happen before we lint and build. It tried to build and lint before we actually made the formatting changes.

[colemacphail]

ok so 2 options here imo, we can either try to figure out why linting is failing (probably different linter settings between the formatter & linter) or we can just stop linting and assume the autoformatter will do a good enough job

I'll let you make that decision but I'm gonna stamp this as soon as CI is green because this is mad annoying

[IanTapply22]

I'm getting rid of linting, I was going to throw that idea out there, but I just want this to be green and it still works. Thanks for the shout

[IanTapply22]

Build still wants what the linter provided, it can't have a successful build if you don't spotless apply 🙄

[colemacphail]

rip spotless 2023-2023

[IanTapply22]

Deserved, was always meant to happen