Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting and build violations #22

Closed
wants to merge 9 commits into from

Conversation

IanTapply22
Copy link
Member

Description

Fixed all linting and build violations with spotless apply.

This PR depends on #20 to be completed and merged before this can be merged. We also need to update the 2024-beta branch to merge this as there are some conflicts with these changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, if any
  • My changes generate no new warnings
  • I have performed tests that prove my fix is effective or that my feature works, if necessary
  • New and existing unit tests pass locally with my changes

@IanTapply22 IanTapply22 added the bug Something isn't working label Nov 12, 2023
@IanTapply22 IanTapply22 self-assigned this Nov 12, 2023
@IanTapply22 IanTapply22 linked an issue Nov 12, 2023 that may be closed by this pull request
README.md Outdated Show resolved Hide resolved
@IanTapply22
Copy link
Member Author

Again, to clarify then this doesn't get messed up. THIS PR DEPENDS ON #20 TO BE MERGED BEFORE MERGING THIS

@colemacphail
Copy link
Member

Again, to clarify then this doesn't get messed up. THIS PR DEPENDS ON #20 TO BE MERGED BEFORE MERGING THIS

@IanTapply22 one cool trick we use at work is that you can set up a github workflow to make it so you can't merge if the PR description has something like "DO_NOT_MERGE" in it. Something to think about if we care lol

@IanTapply22
Copy link
Member Author

Again, to clarify then this doesn't get messed up. THIS PR DEPENDS ON #20 TO BE MERGED BEFORE MERGING THIS

@IanTapply22 one cool trick we use at work is that you can set up a github workflow to make it so you can't merge if the PR description has something like "DO_NOT_MERGE" in it. Something to think about if we care lol

We should totally do that, I'll make an issue for that when I can!

@IanTapply22
Copy link
Member Author

Again, to clarify then this doesn't get messed up. THIS PR DEPENDS ON #20 TO BE MERGED BEFORE MERGING THIS

@IanTapply22 one cool trick we use at work is that you can set up a github workflow to make it so you can't merge if the PR description has something like "DO_NOT_MERGE" in it. Something to think about if we care lol

#25 :)

@colemacphail colemacphail mentioned this pull request Nov 12, 2023
11 tasks
@IanTapply22
Copy link
Member Author

No

@IanTapply22 IanTapply22 deleted the 21/fix-linting-and-build-violations branch November 12, 2023 19:55
@IanTapply22 IanTapply22 restored the 21/fix-linting-and-build-violations branch November 12, 2023 19:55
@IanTapply22 IanTapply22 deleted the 21/fix-linting-and-build-violations branch November 12, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix linting and build violations
2 participants