Positional tracker support #920
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stermere
added
Difficulty: Math Heavy
Stermere
requested review from
ButterscotchV,
Eirenliel and
Erimelowo
as code owners
ImUrX
requested changes
May 10, 2024
ImUrX
approved these changes
Jun 24, 2024
Stermere
force-pushed
the
IKSolver
branch
2 times, most recently
from
1dafe6c
to
43205d1
Compare
ImUrX
requested changes
Jul 23, 2024
server/core/src/main/java/dev/slimevr/tracking/processor/Constraint.kt
Outdated
Show resolved
Hide resolved
server/core/src/main/java/dev/slimevr/tracking/processor/Constraint.kt
Outdated
Show resolved
Hide resolved
server/core/src/main/java/dev/slimevr/tracking/processor/skeleton/IKChain.kt
Outdated
Show resolved
Hide resolved
server/core/src/main/java/dev/slimevr/tracking/processor/skeleton/IKChain.kt
Outdated
Show resolved
Hide resolved
Eirenliel
approved these changes
Jul 30, 2024
|
Would've been cool to use the constraints to correct for drift 🥺 like we know if the bone is out of constraints, then something drifted, and we can at least limit to how bad it looks, and also maybe warn the user. It's a powerful thing that we wanted long ago, and now it feels reachable |
ImUrX
approved these changes
Jul 30, 2024
That is something I am definitely interested in making happen in another PR! You are right though it is certainly reachable with the Constraints as a start |
Stermere
force-pushed
the
IKSolver
branch
2 times, most recently
from
59b1060
to
42c5f62
Compare
…raint.kt Co-authored-by: Uriel <imurx@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an inverse kinematics solver to the skeleton allowing for positional and rotational trackers to be used together. An example would be using 3 positional trackers for the waist and feet and 2 rotational trackers on your leg to add knee-tracking. That is just one example though, any combination of trackers is theoretically supported. Needs SlimeVR/SolarXR-Protocol#139 merged before this can be merged.