Recomputed GT_SnPM8_2017b for failing tests #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing at SnPM-toolbox/SnPM-devel#70 using ground truth data generated for Matlab 2017b, I had some test failins. This PR recomputes the PR for the failing tests which fixes the failure in most cases.
Not sure if this can be explained by a bad generation of the ground truth (e.g. for onesample_1, there was only 1 excursion set instead of 4) or if there is some more serious incompatibility when generating data on Windows and running the tests on Mac OS.
Anyway, I think that in the future we should focus on automating the creation of the ground truth test data (based on current SnPM13). This is open for discussion at #5.