Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

feat: yarn berry + yarn fetch + docker opti #177

Merged
merged 12 commits into from
Aug 14, 2023
Merged

Conversation

devthejo
Copy link
Member

No description provided.

@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
jest-environment-jsdom 29.6.1...29.6.2 None +6/-6 216 kB simenb
jest 29.6.1...29.6.2 None +41/-40 7.42 MB simenb
@babel/core 7.22.9...7.22.10 None +2/-2 5.23 MB nicolo-ribaudo

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@devthejo devthejo requested a review from a team as a code owner August 14, 2023 11:53
@devthejo devthejo temporarily deployed to review-auto August 14, 2023 11:53 — with GitHub Actions Inactive
@devthejo
Copy link
Member Author

devthejo commented Aug 14, 2023

@matmut7 la config talisman pour ignorer le dossier .yarn n'a pas marché, j'ai tenté plusieurs syntaxes mais sans succès du coup j'ai bypass, si t'as une idée

@devthejo devthejo temporarily deployed to review-auto August 14, 2023 12:14 — with GitHub Actions Inactive
@devthejo devthejo temporarily deployed to review-auto August 14, 2023 12:21 — with GitHub Actions Inactive
@devthejo devthejo temporarily deployed to review-auto August 14, 2023 12:28 — with GitHub Actions Inactive
@gitguardian
Copy link

gitguardian bot commented Aug 14, 2023

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
3513932 Generic High Entropy Secret c576a17 .github/workflows/e2e.yml View secret
3513932 Generic High Entropy Secret 84bd3b1 .github/workflows/e2e.yml View secret
3513932 Generic High Entropy Secret 50bded2 .github/workflows/e2e.yml View secret
3513932 Generic High Entropy Secret 981809e .github/workflows/e2e.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@devthejo devthejo temporarily deployed to review-auto August 14, 2023 12:37 — with GitHub Actions Inactive
@devthejo devthejo temporarily deployed to review-auto August 14, 2023 12:51 — with GitHub Actions Inactive
@devthejo devthejo temporarily deployed to review-auto August 14, 2023 12:56 — with GitHub Actions Inactive
@devthejo devthejo temporarily deployed to review-auto August 14, 2023 13:30 — with GitHub Actions Inactive
@devthejo devthejo temporarily deployed to review-auto August 14, 2023 14:00 — with GitHub Actions Inactive
@devthejo devthejo temporarily deployed to review-auto August 14, 2023 14:13 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@maxgfr maxgfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@devthejo devthejo merged commit 76c54b6 into main Aug 14, 2023
19 checks passed
@devthejo devthejo deleted the fix/optimize-dockerfile branch August 14, 2023 14:58
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 1.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@revolunet
Copy link
Member

Il faudrait svp mettre ce plugin sur l'orga socialgouv avant de deployer ailleurs : https://raw.githubusercontent.com/devthejo/yarn-plugin-fetch

@devthejo
Copy link
Member Author

devthejo commented Aug 15, 2023

Il faudrait svp mettre ce plugin sur l'orga socialgouv avant de deployer ailleurs : https://raw.githubusercontent.com/devthejo/yarn-plugin-fetch

la façon de fonctionner des plugins yarn fait qu'il y a une copie locale de l'ensemble du code du plugin qui est commité, donc la reference au repo n'est qu'indicative, il ne va pas install depuis ce repo, et changer la ref dans le yarnrc n'aura aucun impact

je viens de le forker sur SocialGouv pour garder une copie, mais je vais continuer le maintenir personnellement
de plus il est déjà référencé ici https://github.com/yarnpkg/berry/blob/master/packages/gatsby/content/features/plugins.md

je suis également contributeur et co-maintainer de https://github.com/rohit-gohri/yarn-lock-to-package-json/ sur lequel il est basé

@matmut7
Copy link
Member

matmut7 commented Aug 17, 2023

@matmut7 la config talisman pour ignorer le dossier .yarn n'a pas marché, j'ai tenté plusieurs syntaxes mais sans succès du coup j'ai bypass, si t'as une idée

Je crois qu'on ne peut pas simplement ignorer un dossier du scan. On ne peut que whitelist un certain état des fichiers par leur hash. C'est un des défauts de ce système, si on a trop de frustration sur ça il faudra pas hésiter à chercher un autre système

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants