SLCORE-1031 Modify label for missing binding on hotspots #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nquinquenel
force-pushed
the
feature/nq/SLCORE-1031-rebranding-hotspot
branch
from
21cd2b6
to
5b01c52
Compare
|
thahnen
requested changes
Nov 8, 2024
| @@ -84,7 +84,7 @@ void it_should_not_support_local_detection_in_standalone_mode() { | |||
|
|
|||
| assertThat(checkResponse) | |||
| .extracting(CheckLocalDetectionSupportedResponse::isSupported, CheckLocalDetectionSupportedResponse::getReason) | |||
| .containsExactly(false, "The project is not bound, please bind it to SonarQube 9.9+ or SonarCloud"); | |||
| .containsExactly(false, "The project is not bound, please bind it to SonarQube (Server, Cloud)"); | |||
There was a problem hiding this comment.
I've read the branding guide but reading this feels super bad.
There was a problem hiding this comment.
I agree, maybe here we could afford to spell it out SonarQube Server or SonarQube Cloud. But not a blocker from my perspective.
backend/core/src/main/java/org/sonarsource/sonarlint/core/hotspot/HotspotService.java
Show resolved
Hide resolved
sophio-japharidze-sonarsource
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLCORE-1031