Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLCORE-1031 Modify label for missing binding on hotspots #1154

Merged
merged 1 commit into from
Nov 11, 2024
Merged

SLCORE-1031 Modify label for missing binding on hotspots #1154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/core/src/main/java/org/sonarsource/sonarlint/core/OrganizationsCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public List<OrganizationDto> fuzzySearchOrganizations(Either<TokenDto, UsernameP
.entrySet()
.stream()
.sorted(Comparator.comparing(Map.Entry<OrganizationDto, Double>::getValue).reversed()
.thenComparing(Comparator.comparing(e -> e.getKey().getName(), String.CASE_INSENSITIVE_ORDER)))
.thenComparing(e -> e.getKey().getName(), String.CASE_INSENSITIVE_ORDER))
.limit(10)
.map(Map.Entry::getKey)
.collect(Collectors.toList());
Expand Down
2 changes: 1 addition & 1 deletion backend/core/src/main/java/org/sonarsource/sonarlint/core/hotspot/HotspotService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
public class HotspotService {

private static final SonarLintLogger LOG = SonarLintLogger.get();
private static final String NO_BINDING_REASON = "The project is not bound, please bind it to SonarQube 9.9+ or SonarCloud";
private static final String NO_BINDING_REASON = "The project is not bound, please bind it to SonarQube (Server, Cloud)";
thahnen marked this conversation as resolved.
Show resolved Hide resolved

private static final String REVIEW_STATUS_UPDATE_PERMISSION_MISSING_REASON = "Changing a hotspot's status requires the 'Administer Security Hotspot' permission.";
private final SonarLintRpcClient client;
Expand Down
2 changes: 1 addition & 1 deletion medium-tests/src/test/java/mediumtest/hotspots/HotspotLocalDetectionSupportMediumTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ void it_should_not_support_local_detection_in_standalone_mode() {

assertThat(checkResponse)
.extracting(CheckLocalDetectionSupportedResponse::isSupported, CheckLocalDetectionSupportedResponse::getReason)
.containsExactly(false, "The project is not bound, please bind it to SonarQube 9.9+ or SonarCloud");
.containsExactly(false, "The project is not bound, please bind it to SonarQube (Server, Cloud)");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read the branding guide but reading this feels super bad.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, maybe here we could afford to spell it out SonarQube Server or SonarQube Cloud. But not a blocker from my perspective.

}

@Test
Expand Down