-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overrides check #257
Overrides check #257
Conversation
SpiNNakerManchester/SpiNNMachine#233 was used to test the error came in the correct place. http://apollo.cs.man.ac.uk:8080/blue/organizations/jenkins/Integration%20Tests/detail/overrides_check/1/pipeline/ http://apollo.cs.man.ac.uk:8080/blue/organizations/jenkins/Integration%20Tests/detail/overrides_check/4/pipeline/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - consider this approval of the rest if the test passes!
This pr is in a few parts.
Improved typing in the ranged stuff
Added types to many methods
Must be done after:
SpiNNakerManchester/SpiNNMan#386
SpiNNakerManchester/PACMAN#537
SpiNNakerManchester/SpiNNFrontEndCommon#1150
SpiNNakerManchester/TestBase#53
SpiNNakerManchester/sPyNNaker#1425
SpiNNakerManchester/SupportScripts#67
SpiNNakerManchester/SpiNNakerGraphFrontEnd#268
SpiNNakerManchester/SpiNNGym#86
SpiNNakerManchester/MarkovChainMonteCarlo#60
SpiNNakerManchester/SpiNNaker_PDP2#84
SpiNNakerManchester/SupportScripts#67
SpiNNakerManchester/sPyNNakerNewModelTemplate#110
Tested by:
SpiNNakerManchester/IntegrationTests#255