Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overrides check #1425

Merged
merged 40 commits into from
Jan 15, 2024
Merged

Overrides check #1425

merged 40 commits into from
Jan 15, 2024

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Dec 19, 2023

Part of SpiNNakerManchester/SpiNNUtils#257

All typing changes and the below tiny changes

FromListConnector

  • get_n_connections_from_pre_vertex_maximum simplified to help the TypeGuard

SpikeSourcePoissonVertex

  • set_parameter_values uses is_iterable TypeGuard

SynapseDynamicsSTDP

  • merge bug fix on call to SynapseDynamicsStructuralSTDP

SynapseDynamicsStructuralSTDP and SynapseDynamicsStructuralSTDP

  • fixed is_same_as so that type must match and both parent is_same_as must pass

DataPopulation

  • describe fixed ignore logs

AbstractSynapseDynamicsStructural

SynapseDynamicsStructuralStatic

LocalOnlyConvolution

  • write_parameters fixed call to get_parameters_usage_in_bytes (param was wrong but unused)

DelayExtensionMachineVertex

  • added and used overridden
  • app_vertex property which returns a DelayExtensionVertex (or errors out)

ExternalDeviceLifControlVertex
init drop_late_spikes default move from param to inside method

Other none code none typing changes

adds PopulationApplicationVertex and MDSlice to the spelling exceptions

fix a spelling in a comment

one docs remove and overrides tag added

@coveralls
Copy link

coveralls commented Dec 19, 2023

Coverage Status

coverage: 67.989% (-1.1%) from 69.136%
when pulling e4c3206 on overrides_check
into 7b68d2e on master.

@Christian-B Christian-B merged commit 23f1e75 into master Jan 15, 2024
8 of 10 checks passed
@Christian-B Christian-B deleted the overrides_check branch January 15, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants