Fix Mhz -> MHz in README, comments and Dhrystone benchmark output #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SI units are case sensitive and analog engineers are very sensitive to this :)
It seems that the Dhrystone benchmark is done with .asm files, perhaps generated from here, where Hz is wrongly spelled "hz".
This PR fix this in the README, the scala code that seems to generate the README but not the .asm files.
Ideally a fix in the upstream C code repos would also be needed, but IMHO it's not a good idea, because it would break too many tests like this one.
Note that I didn't test the fix in the scala file because I don't have a running VexRiscv setup.