-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added nsi script #31
added nsi script #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, noted sth below.
Also, can you move this file to the snippets
folder? That way we don't have to create yet another folder in the repo root
nsi script/script.nsi
Outdated
StrCpy $INSTDIR $EXEDIR | ||
StrCpy $INSTDIR "$INSTDIR\logicrs" | ||
SetOutPath $INSTDIR | ||
File /r "F:\exe\logicrs-windows-x86_64\*.*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be a relative path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just so i understand it, the line File /r will fetch all the files from that directory and you want it to be relative? Is that it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you ask me, File /r "path*.*" is fine with being absolute, rather it's good it's that way.
Using $EXEDIR (for installation directory) is more important since it fetches the current directory path.
If you want to try a relative path for fetching files for exe, can you specify any example directory like how the files and folders are on ur end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I have made a script for relative path and here's the sample directory I used:
When you load the nsi script in NSIS, it will generate the .exe you see in the 2nd image.
I have tested it out in a different folder, and when we double click it will create a new folder logicrs and install the files in that:
Can I push this code or do you want more changes? @Spydr06
Outfile "logicrs-windows-x86_64.exe"
Section
StrCpy $INSTDIR $EXEDIR
StrCpy $INSTDIR "$INSTDIR\logicrs"
SetOutPath $INSTDIR
File /r "win-files\*.*"
SectionEnd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that way it's better, looks good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will commit the new script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the PR, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow the deleted commit didn't took place in my previous commit, I have just fixed it @Spydr06.
Ok I will move the file |
NSI script for NSIS #20