Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added nsi script #31

Merged
merged 4 commits into from
Oct 3, 2023
Merged

added nsi script #31

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a2a6ab
added nsi script
VoidVampire Oct 2, 2023
ea4d14f
changed directories
VoidVampire Oct 3, 2023
1ab9c93
added relative path
VoidVampire Oct 3, 2023
44af77d
Delete nsi script directory
VoidVampire Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions nsi script/script.nsi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Outfile "logicrs-windows-x86_64.exe"
Section
StrCpy $INSTDIR $EXEDIR
StrCpy $INSTDIR "$INSTDIR\logicrs"
SetOutPath $INSTDIR
File /r "F:\exe\logicrs-windows-x86_64\*.*"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be a relative path?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just so i understand it, the line File /r will fetch all the files from that directory and you want it to be relative? Is that it?

Copy link
Contributor Author

@VoidVampire VoidVampire Oct 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you ask me, File /r "path*.*" is fine with being absolute, rather it's good it's that way.
Using $EXEDIR (for installation directory) is more important since it fetches the current directory path.

If you want to try a relative path for fetching files for exe, can you specify any example directory like how the files and folders are on ur end?

Copy link
Contributor Author

@VoidVampire VoidVampire Oct 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I have made a script for relative path and here's the sample directory I used:

image
image

When you load the nsi script in NSIS, it will generate the .exe you see in the 2nd image.

I have tested it out in a different folder, and when we double click it will create a new folder logicrs and install the files in that:
image

Can I push this code or do you want more changes? @Spydr06

Outfile "logicrs-windows-x86_64.exe"
Section
    StrCpy $INSTDIR $EXEDIR
    StrCpy $INSTDIR "$INSTDIR\logicrs"
    SetOutPath $INSTDIR
    File /r "win-files\*.*"
SectionEnd

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that way it's better, looks good :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will commit the new script

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the PR, thanks.

Copy link
Contributor Author

@VoidVampire VoidVampire Oct 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow the deleted commit didn't took place in my previous commit, I have just fixed it @Spydr06.

SectionEnd
Loading