Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving all dockerfiles into a "build-files" directory #1119

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

erinyoung
Copy link
Contributor

This is updating the main file structure for this repository.

After a little consideration, I think updating the file structure is required BEFORE updating the github actions looking for new dockerfiles - otherwise each Dockerfile would be built.

@erinyoung erinyoung changed the title made conditional to StaPH-B Moving all dockerfiles into a "recipes" directory Dec 9, 2024
@erinyoung
Copy link
Contributor Author

This PR is very large, but only because so many files were renamed.

Notable changes:

  1. The github actions that operate through cron jobs now will only run if connect to StaPH-B/docker-builds (not on any forks)
  2. All bioinformatic tools are in the recipes directory - so 99% of the changes are renaming files
  3. parsnp/README.md was deleted as this file is found in each version subdirectory
  4. artic-ncov2019-medaka and artic-ncov2019-nanopolish now have a 1.1.0 subdirectory and their Dockerfile has been moved into that subdirectory
  5. chmod -x was run on all Dockerfiles to remove all executability

@Kincekara
Copy link
Collaborator

Kincekara commented Dec 10, 2024

@erinyoung where are the dockerfile templates? Are you planning to add them later?

@erinyoung
Copy link
Contributor Author

Oh no! I didn't think I did anything to them! Did I accidentally delete them?

@Kincekara
Copy link
Collaborator

I couldn't see them. In any case, it may be good to have those templates outside the recipes folder.

@erinyoung
Copy link
Contributor Author

I can't see where I've moved them, so they should be where they currently are

@Kincekara
Copy link
Collaborator

@erinyoung I am sorry, It's my mistake. I was trying to see changes in the pull request. When I checked your branch, I didn't see any problem.

@erinyoung erinyoung changed the title Moving all dockerfiles into a "recipes" directory Moving all dockerfiles into a "build-files" directory Dec 12, 2024
@erinyoung
Copy link
Contributor Author

The subdirectory is now 'build-files'!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants