Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multi cm example #8

Closed
wants to merge 26 commits into from
Closed

Fix multi cm example #8

wants to merge 26 commits into from

Conversation

christophfroehlich
Copy link

I merged the last commit before the restructuring into this branch, now it compiles.

Furthermore, I made the example work with rolling

  • new spawner syntax
  • new ros2controlcli syntax
  • ros2 controllers test nodes parameters

Should we then include this into ros-controls#187 to one complete multi-robot example?

destogl and others added 26 commits March 30, 2022 09:31
@destogl
Fix Python black pre-commit hook (ros-controls#164)
07e8d41
@mamueluth
Changed JointStateController to JointStateBroadcaster in instructions (…
96ef3b5 
…ros-controls#168)

Changed JointStateController to JointStateBroadcaster in instructions
@ikamii
CallbackReturn Fix (ros-controls#173)
c02942a
@destogl @bmagyar
Fix up small error in example docs (ros-controls#174)
a3a792f 
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
@bmagyar
Pass time and period to read() and write() (ros-controls#179)
6bd6631 
* Pass time and period to read() and write()

* Remove obsolete time variables

* Fix whitespace
Add First-Time Users section to the README (ros-controls#181)
48bb610 
* Add First-Time Users section to the README

* Format
Fix warning about "output" from launch files (ros-controls#183)
2fae87b
Replace use_sim with use_gazebo (ros-controls#182)
88d12f9
@destogl
Fix missing correction of output parameter on Nodes in launch files. (r…
aabf2cd 
…os-controls#192)

* Fix missing correction of output parameter on Nodes in launch files.

* Update test_joint_trajectory_controller.launch.py
@bmagyar
Use mock hardware instead of fake hardware plugin package (ros-contro…
fe14bf3 
…ls#188)
@destogl
Fix DLL export defintion. (ros-controls#195)
ee92329
@destogl
Fix bug that doesn't reset commands properly on activation. (ros-cont…
e4c9ba4 
…rols#194)

Resolves ros-controls#178
@destogl
Publish to correct topic in DiffBot example (ros-controls#196)
fe23072
@HusamZain @destogl
fixing command line in Step 5 in diffbot example (ros-controls#155)
41a8fa5 
Co-authored-by: Denis Štogl <denis@stogl.de>
@destogl
Fix output parameter in launch files for testing controllers. (ros-co…
f42b06f 
…ntrols#197)
@Interactics
Fix some typos (ros-controls#205)
4329be0
@jaron-l
ci: 👷 update rhel container (ros-controls#212)
a5ed904
@bmagyar
Remove ros index links (ros-controls#204)
6478457
@kvkpraneeth
fake_sensor_commands replaced (ros-controls#200)
4abae28
@t3ch9
Demo 5b broken, update code fixed (ros-controls#208)
041ab7e
@destogl
🔧 Fixes and updated on pre-commit hooks and their action. (ros-contro…
de1012a 
…ls#218)

* Use pydocstyle instead of pep257 because it replaces it. Bump versions of hooks.

* Remove fixed python version from formatting action. Fix action warnings about Node.js 12 by updating them. Bump version of clang-format.

* correct formatting.
@destogl
[CI] Add dependabot to automatically update actions in workflows (ros…
e38961c 
…-controls#219)
@dependabot
Bump codecov/codecov-action from 1.0.14 to 3.1.1 (ros-controls#221)
9c7c04e 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@destogl
Update list of possible reviewers
b393963
@christophfroehlich
Merge commit 'b3939631e3586c3a14c53099065b9870afb1a3c4' into multi-cm…
53f930e 
…-example
@christophfroehlich
Bump example to latest ros2_control(ler) syntax
11e2c88
@christophfroehlich christophfroehlich mentioned this pull request Dec 25, 2023
Merged
@christophfroehlich
Copy link
Author

Closing in favor of ros-controls#423

@mergify mergify bot mentioned this pull request May 28, 2024
Merged
@mergify mergify bot mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@christophfroehlich @destogl @mamueluth @ikamii @bmagyar @HusamZain @Interactics @jaron-l @kvkpraneeth @t3ch9