[Example 15] Using multiple controller managers under different namespaces #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 25, 2023
christophfroehlich
force-pushed
the
rebase_170
branch
from
cd34784
to
cb45f95
Compare
github-actions
bot
requested review from
destogl,
jaron-l,
olivier-stasse,
progtologist,
VanshGehlot and
VX792
saikishor
requested changes
Dec 27, 2023
christophfroehlich
force-pushed
the
rebase_170
branch
from
f49b910
to
116bef9
Compare
Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
christophfroehlich
force-pushed
the
rebase_170
branch
from
116bef9
to
ba85155
Compare
|
This pull request is in conflict. Could you fix it @christophfroehlich? |
olivier-stasse
approved these changes
May 28, 2024
|
I don't understand which change is missing from @saikishor review. |
Thanks for your review. I addressed his comments, only the final approval was missing. |
mergify bot
pushed a commit
that referenced
this pull request
May 28, 2024
…paces (#423) * Add example15 to workflows+packages * Initial commit from old PR Co-authored-by: Denis Štogl <destogl@users.noreply.github.com> * Convert md to rst syntax * Apply suggestions from code review Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com> --------- Co-authored-by: Denis Štogl <destogl@users.noreply.github.com> Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com> (cherry picked from commit a97760f)
mergify bot
pushed a commit
that referenced
this pull request
May 28, 2024
…paces (#423) * Add example15 to workflows+packages * Initial commit from old PR Co-authored-by: Denis Štogl <destogl@users.noreply.github.com> * Convert md to rst syntax * Apply suggestions from code review Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com> --------- Co-authored-by: Denis Štogl <destogl@users.noreply.github.com> Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com> (cherry picked from commit a97760f)
christophfroehlich
added a commit
that referenced
this pull request
May 28, 2024
…paces (#423) (#527) * Add example15 to workflows+packages * Initial commit from old PR Co-authored-by: Denis Štogl <destogl@users.noreply.github.com> * Convert md to rst syntax * Apply suggestions from code review Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com> --------- Co-authored-by: Denis Štogl <destogl@users.noreply.github.com> Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com> (cherry picked from commit a97760f) Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
christophfroehlich
added a commit
that referenced
this pull request
May 28, 2024
…paces (#423) (#526) * Add example15 to workflows+packages * Initial commit from old PR Co-authored-by: Denis Štogl <destogl@users.noreply.github.com> * Convert md to rst syntax * Apply suggestions from code review Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com> --------- Co-authored-by: Denis Štogl <destogl@users.noreply.github.com> Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com> (cherry picked from commit a97760f) Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rewrite of #170 including StoglRobotics-forks#8
An open questions for me: