Add support for dual OPL #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mywave82
commented
Jun 25, 2023
mywave82
commented
- 2 other minor fixes
==18263== Invalid read of size 1 ==18263== at 0x17AA4B: RetroWavePlayer::osd_show_regmaps() (OSD.cpp:246) ==18263== by 0x17AF0A: RetroWavePlayer::osd_show() (OSD.cpp:307) ==18263== by 0x177CF3: RetroWavePlayer::flush_and_sleep(unsigned int) (SoundDriver.cpp:271) ==18263== by 0x177AF1: RetroWavePlayer::callback_sleep(void*, unsigned char, void const*, unsigned int) (SoundDriver.cpp:236) ==18263== by 0x113616: tvc_callback_command(void*, unsigned int, void const*, unsigned int) (Player.cpp:106) ==18263== by 0x187B8C: tinyvgm_parse_commands (in /home/stian/RetroWave/build/RetroWave_Player) ==18263== by 0x114656: RetroWavePlayer::play(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&) (Player.cpp:375) ==18263== by 0x116622: main (Player.cpp:565) ==18263== Address 0x5012e1e is 0 bytes after a block of size 190 alloc'd ==18263== at 0x4843FA3: operator new(unsigned long) (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==18263== by 0x13C474: std::__new_allocator<unsigned char>::allocate(unsigned long, void const*) (new_allocator.h:137) ==18263== by 0x136DD6: std::allocator_traits<std::allocator<unsigned char> >::allocate(std::allocator<unsigned char>&, unsigned long) (alloc_traits.h:464) ==18263== by 0x12FC7D: std::_Vector_base<unsigned char, std::allocator<unsigned char> >::_M_allocate(unsigned long) (stl_vector.h:378) ==18263== by 0x1295C0: std::vector<unsigned char, std::allocator<unsigned char> >::_M_default_append(unsigned long) (vector.tcc:650) ==18263== by 0x123F00: std::vector<unsigned char, std::allocator<unsigned char> >::resize(unsigned long) (stl_vector.h:1011) ==18263== by 0x180A81: RetroWavePlayer::regmap_insert(int, unsigned char, unsigned char) (RegMap.cpp:51) ==18263== by 0x17768E: RetroWavePlayer::callback_opl3_port0(void*, unsigned char, void const*, unsigned int) (SoundDriver.cpp:148) ==18263== by 0x11392A: tvc_callback_command(void*, unsigned int, void const*, unsigned int) (Player.cpp:133) ==18263== by 0x187B8C: tinyvgm_parse_commands (in /home/stian/RetroWave/build/RetroWave_Player) ==18263== by 0x114656: RetroWavePlayer::play(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&) (Player.cpp:375) ==18263== by 0x116622: main (Player.cpp:565) ==18263== ==18263== Use of uninitialised value of size 8 ==18263== at 0x4C5C082: _itoa_word (_itoa.c:178) ==18263== by 0x4C65F7A: __printf_buffer (vfprintf-process-arg.c:155) ==18263== by 0x4C67B30: __vfprintf_internal (vfprintf-internal.c:1459) ==18263== by 0x4C5CF9E: printf (printf.c:33) ==18263== by 0x17AA66: RetroWavePlayer::osd_show_regmaps() (OSD.cpp:246) ==18263== by 0x17AF0A: RetroWavePlayer::osd_show() (OSD.cpp:307) ==18263== by 0x177CF3: RetroWavePlayer::flush_and_sleep(unsigned int) (SoundDriver.cpp:271) ==18263== by 0x177AF1: RetroWavePlayer::callback_sleep(void*, unsigned char, void const*, unsigned int) (SoundDriver.cpp:236) ==18263== by 0x113616: tvc_callback_command(void*, unsigned int, void const*, unsigned int) (Player.cpp:106) ==18263== by 0x187B8C: tinyvgm_parse_commands (in /home/stian/RetroWave/build/RetroWave_Player) ==18263== by 0x114656: RetroWavePlayer::play(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&) (Player.cpp:375) ==18263== by 0x116622: main (Player.cpp:565)
|
many thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.