Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for dual OPL #6

Merged
merged 3 commits into from
Jun 25, 2023
Merged

Add support for dual OPL #6

merged 3 commits into from
Jun 25, 2023

Commits on Jun 25, 2023

  1. Update to the latest version of TinyVGM, so that dual OPL can be play… 

    …ed back.
    @mywave82
    mywave82 committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    8ab9e8d View commit details
    Browse the repository at this point in the history

  2. Use the correct format specificier for size_t

    @mywave82
    mywave82 committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    f59c8fd View commit details
    Browse the repository at this point in the history

  3. Simple fix that removes errors reported by valgrind: 

    ==18263== Invalid read of size 1
==18263==    at 0x17AA4B: RetroWavePlayer::osd_show_regmaps() (OSD.cpp:246)
==18263==    by 0x17AF0A: RetroWavePlayer::osd_show() (OSD.cpp:307)
==18263==    by 0x177CF3: RetroWavePlayer::flush_and_sleep(unsigned int) (SoundDriver.cpp:271)
==18263==    by 0x177AF1: RetroWavePlayer::callback_sleep(void*, unsigned char, void const*, unsigned int) (SoundDriver.cpp:236)
==18263==    by 0x113616: tvc_callback_command(void*, unsigned int, void const*, unsigned int) (Player.cpp:106)
==18263==    by 0x187B8C: tinyvgm_parse_commands (in /home/stian/RetroWave/build/RetroWave_Player)
==18263==    by 0x114656: RetroWavePlayer::play(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&) (Player.cpp:375)
==18263==    by 0x116622: main (Player.cpp:565)
==18263==  Address 0x5012e1e is 0 bytes after a block of size 190 alloc'd
==18263==    at 0x4843FA3: operator new(unsigned long) (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==18263==    by 0x13C474: std::__new_allocator<unsigned char>::allocate(unsigned long, void const*) (new_allocator.h:137)
==18263==    by 0x136DD6: std::allocator_traits<std::allocator<unsigned char> >::allocate(std::allocator<unsigned char>&, unsigned long) (alloc_traits.h:464)
==18263==    by 0x12FC7D: std::_Vector_base<unsigned char, std::allocator<unsigned char> >::_M_allocate(unsigned long) (stl_vector.h:378)
==18263==    by 0x1295C0: std::vector<unsigned char, std::allocator<unsigned char> >::_M_default_append(unsigned long) (vector.tcc:650)
==18263==    by 0x123F00: std::vector<unsigned char, std::allocator<unsigned char> >::resize(unsigned long) (stl_vector.h:1011)
==18263==    by 0x180A81: RetroWavePlayer::regmap_insert(int, unsigned char, unsigned char) (RegMap.cpp:51)
==18263==    by 0x17768E: RetroWavePlayer::callback_opl3_port0(void*, unsigned char, void const*, unsigned int) (SoundDriver.cpp:148)
==18263==    by 0x11392A: tvc_callback_command(void*, unsigned int, void const*, unsigned int) (Player.cpp:133)
==18263==    by 0x187B8C: tinyvgm_parse_commands (in /home/stian/RetroWave/build/RetroWave_Player)
==18263==    by 0x114656: RetroWavePlayer::play(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&) (Player.cpp:375)
==18263==    by 0x116622: main (Player.cpp:565)
==18263==
==18263== Use of uninitialised value of size 8
==18263==    at 0x4C5C082: _itoa_word (_itoa.c:178)
==18263==    by 0x4C65F7A: __printf_buffer (vfprintf-process-arg.c:155)
==18263==    by 0x4C67B30: __vfprintf_internal (vfprintf-internal.c:1459)
==18263==    by 0x4C5CF9E: printf (printf.c:33)
==18263==    by 0x17AA66: RetroWavePlayer::osd_show_regmaps() (OSD.cpp:246)
==18263==    by 0x17AF0A: RetroWavePlayer::osd_show() (OSD.cpp:307)
==18263==    by 0x177CF3: RetroWavePlayer::flush_and_sleep(unsigned int) (SoundDriver.cpp:271)
==18263==    by 0x177AF1: RetroWavePlayer::callback_sleep(void*, unsigned char, void const*, unsigned int) (SoundDriver.cpp:236)
==18263==    by 0x113616: tvc_callback_command(void*, unsigned int, void const*, unsigned int) (Player.cpp:106)
==18263==    by 0x187B8C: tinyvgm_parse_commands (in /home/stian/RetroWave/build/RetroWave_Player)
==18263==    by 0x114656: RetroWavePlayer::play(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&) (Player.cpp:375)
==18263==    by 0x116622: main (Player.cpp:565)
    @mywave82
    mywave82 committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    a065efd View commit details
    Browse the repository at this point in the history